4 ms·
Hey, a rationale, something I seldom see in those debates :) I think that if you do want to align, spaces are unavoidable. But I want to reiterate three points
by scrollaway 10y ago
Hey, a rationale, something I seldom see in those debates :)
I think that if you do want to align, spaces are unavoidable. But I want to reiterate three points against alignment:
- Alignment creates a maintenance burden. It has to be updated whenever you touch unrelated lines, which creates whitespace noise.
- Some types of alignments (specifically, method parameter alignment) create extreme horizontal noise. See for yourself: https://github.com/pennersr/django-allauth/blob/c9b31ddee81d2cde06c1f686c4eb7703f916681f/allauth/account/views.py#L629-L632 https://github.com/pennersr/django-allauth/blob/c9b31ddee81d...
That stuff's ridiculous. Styleguides are meant to make the code more readable and maintainable - this is neither. Method calls can be defined just like arrays, where the first argument goes on a newline with a single added indent. No need to align anything.
- Finally, alignment breaks with proportional fonts. This is something someone else brought up on HN in another topic and I think it's a really good point; proportional fonts, like tabs, are an accessibility feature.
- patrickmay 10y ago> - Some types of alignments (specifically, method parameter alignment) create extreme horizontal noise. See for yourself: https://github.com/pennersr/django-allauth/blob/c9b31ddee81d.. https://github.com/pennersr/django-allauth/blob/c9b31ddee81d.... The answer there would be to put the line break before the . and align the .dispatch under super.