6 ms·
> Since the configuration file is kept in the same repository as the code, configuration options or secrets can easily be changed or added by developers themsel
by koolba 10y ago
> Since the configuration file is kept in the same repository as the code, configuration options or secrets can easily be changed or added by developers themselves.
This is terrible advice. Code and config should be separate. Otherwise you can't deploy the same code to a different environment.
- NickBusey 10y agoYup. Storing config and code together is a violation of the Twelve-Factor App methodology. https://12factor.net/config https://12factor.net/config
- sleepychu 10y agoIs this methodology accepted as state of the art or used by the author of this article? I don't see why breaking this particular set of rules is an issue.
- mafro 10y agoI keep hearing this "violation of Twelve-Factor" statement. The Twelve-Factor Methodology is a sensible set of guidelines/defaults for building a modern app, as written by Heroku. Don't blindly follow it As It Was Written without thinking. Seriously, do what works. Use your brain. Using this statement as an argument against other methods is sending the wrong message.
- andreasklinger 10y agowhat's your counter argument/proposal ?
- hueving 10y agoThey are just guidelines. "violating them" means absolutely nothing so claiming so adds nothing to the conversation.
- mafro 10y agoThis is exactly what I meant.
- nickpsecurity 10y agoHere's my interpretation of the link: https://news.ycombinator.com/item?id=12344971 https://news.ycombinator.com/item?id=12344971
- nickpsecurity 10y agoThe linked part about config makes sense. It's a specific instance of a general concept that shows up in hardware and software engineering. That's that things that reusable things that don't change should be separated from those that change often. In this case, we have code and [configuration] data. The data can and will vary considerably while reusing the same code. They should be separate so data changes don't require recompilation. Further, any change of code can change its behavior. Better to have code that's already vetted via review and testing to handle specific types of input data. That way you can keep changing the data without re-assessing the code. There's also a minor benefit in efficiency when you can re-use binaries already created and integration tested while just generating new configuration data. Those minor things can add up if you're constrained in CPU/memory.
- hamax 10y ago> data can and will vary considerably while reusing the same code. This is the complete opposite of my experience. We deploy new code to production 10 times per day and change configuration a couple of times per month. What do you keep in configuration that changes this often?
- nickpsecurity 10y agoWell, it depends on internal projects vs external ones. Internal ones might work as you described. External ones will have many more deployments than code changes for a given module.
- hamax 10y agoAgreed. I always worked with internal project so it didn't cross my mind.
- mafro 10y agoI agree with everything you say! Notice I'm not saying that the 12 Factor App is incorrect or bad - I think it's quite the opposite. It just concerns me that people treat it as gospel, and quote it like it's some holy work that cannot be disagreed with.
- strictfp 10y agoUnless your code is like 99% of all the code I've seen ,where you only deploy to a handful of locations, and it's really handy to just say '-profile=stage'. Besides, including config in the build does not preclude being able to pass it in as well.
- deleted 10y ago[deleted]
- newsat13 10y agoYou can have per environment config files
- hamax 10y agoWe deploy code to 3 datacenters so we simply have 3 config files in the repository. Deploy script then decides to link the correct config for the environment. If you want to run local environment you can simply create your own configuration. I don't really see what you gain by moving configuration files into a separate repository.
- nathancahill 10y agoThat's pretty standard and accepted. Don't know what gp is talking about.
- koolba 10y ago> If you want to run local environment you can simply create your own configuration. Externalizing config forces you to cleanly handle local environments as well. There's nothing special about them. I generally recommend having an env.example file listing out required environment variables with sensible local defaults. This eases onboarding a new developer or even an existing developer on a new machine. > I don't really see what you gain by moving configuration files into a separate repository. Because config and code should be kept separate. Updating the database that your production app is using is not a code change. It's a config change. Setting up a new CI environment should not require pushing new code. If you have a production issue in version X, separating code and config allows you to reproduce it using an isolated database/mq/foobar service. It's exactly the same code.
- hamax 10y agoI'm sorry but I really don't understand how having env.production.toml commited in the same repository as code makes anything that you said impossible/more difficult. I can always grab the build from production and run it locally with the modified config.
- jimktrains2 10y ago> env.production.toml Which production env? Which datacenter? Which database cluster? &c The deployment should take care of generating configs, they shouldn't be hardcoded or stored anywhere imho.