3 ms·

This seems like a good use case for a bit mask query function. I see Rust has a bitflags crate: https://doc.rust-lang.org/bitflags/bitflags/index.html https://

This seems like a good use case for a bit mask query function. I see Rust has a bitflags crate: https://doc.rust-lang.org/bitflags/bitflags/index.html https://doc.rust-lang.org/bitflags/bitflags/index.html

bluejekyll 10y ago
I found that after I had already written a lot of that code. I haven't had much reason to go back and change it, but any PR's if someone wants to do it, would be accepted.
- deleted 10y ago
  [deleted]
- vog 10y ago
  What about simply replacing all "== 0b..." with "!= 0"? That would already be a good improvement, both in terms of DRY and readability, without the need of adding another dependency.
  - sedatk 10y ago
    It wouldn't be the same thing. For instance x & 0b11 != 0 can return true for multiple values of x, 0b10 and 0b01 respectively.
    - vog 10y ago
      I see. You are sometimes checking for multiple bits at once. Didn't notice that.