3 ms·
I noticed that the C++ code has no comments whatsoever. Why would they do that? The code is clear enough and you can read the papers to figure it out or do they
by slig 10y ago
I noticed that the C++ code has no comments whatsoever. Why would they do that? The code is clear enough and you can read the papers to figure it out or do they clean up comments before releasing internal code to the public?
- bdcravens 10y agoI suspect it's the latter, since code not initially OSS likely has some references to IP, or org structure, some crudeness, etc. Probably easier to remove it all than rewrite. Adding comments back in would be a great start to contributing to OSS.
- michael_storm 10y agoI think open-sourcing the code in the first place was a great start to contributing to OSS. Facebook isn't a newcomer to the community.
- whafro 10y agoI took bdcravens' comment to mean it'd be a great project for someone who wanted a way to start contributing to OSS, not a suggestion that Facebook wasn't contributing.
- michael_storm 10y agoOh, you're right. Whoops.
- bdcravens 10y agoLike whafro said, that wasn't what I was trying to suggest. Never meant to denigrate their contribution, only saying that parts that were never intended to be open (like comments) were probably removed rather than rewritten, which is perfectly acceptable and consistent with their great open source contributions.
- michael_storm 10y agoSorry about that; I misunderstood your comment.
- spicyj 10y agoWe usually strip the commit history since it's hard to audit the history for confidential info, but we don't normally remove comments when open-sourcing things. I'm not sure on the specifics of this case though.