3 ms·
I wish Github had a way of running these sort of checks before accepting/rejecting a push. (I can understand why they would be reluctant to run arbitrary user-
by samstokes 10y ago
I wish Github had a way of running these sort of checks before accepting/rejecting a push. (I can understand why they would be reluctant to run arbitrary user-supplied bash on their servers, though :))
- cheald 10y agoIn the Github case it's probably better to run these checks as part of your CI process and fail the build if they raise alarms.
- praseodym 10y agoThe GitHub flow [1] is to use pull requests for everything. Aside from being a great code review tool, you can execute CI and other checks on them, even making it required for those checks to pass before merging [2]. You can quite easily hook your own checks [3], like the one from the original post or even a check whether the committer signed a CLA (Spring Boot does this [4]). [1] https://guides.github.com/introduction/flow/ https://guides.github.com/introduction/flow/ [2] https://help.github.com/articles/enabling-required-status-checks/ https://help.github.com/articles/enabling-required-status-ch... [3] https://developer.github.com/v3/repos/statuses/ https://developer.github.com/v3/repos/statuses/ [4] https://github.com/spring-projects/spring-boot https://github.com/spring-projects/spring-boot
- daveguy 10y agoGitLab does provide this capability. They have a free CI thread even on the free accounts. GitLab is much better than GitHub. Edit: well, maybe not exactly this functionality. It is CI based and not hook based. Still free CI thread is pretty awesome and can be used in this type of application.