4 ms·
This is an amazing idea, and I will be implementing this today. Great job. I haven't seen any rendering problems across browsers either. The only change I woul
by xpose2000 10y ago
This is an amazing idea, and I will be implementing this today. Great job. I haven't seen any rendering problems across browsers either.
The only change I would make is to remove the "Share on Twitter" text that is included with each large button on the website example. It's pretty much implied for the end user once they see the colors of the buttons and the icons.
For example, I shortened "Share on Twitter" to just "Twitter".
- niftich 10y agoAlong this point, I feel the 'medium' preset's removal of the logos is odd as it's not typically done. I'd rather see the medium preset be '[logo] Twitter' instead.
- mxstbr 10y agoThose actually sound like a brilliant idea! Would you mind submitting an issue so I don't forget it? (or submit a PR?) https://github.com/mxstbr/sharingbuttons.io https://github.com/mxstbr/sharingbuttons.io
- xpose2000 10y agoI submitted an issue mentioning both ideas. In fact, medium & large can be combined into one layout called "normal".