3 ms·

Looks really cool. I hope you don't mind (I see it's your first free software project), but I've opened a PR to add GPLv3 notices so that it's easier to find ou

by cyphar 10y ago

Looks really cool. I hope you don't mind (I see it's your first free software project), but I've opened a PR to add GPLv3 notices so that it's easier to find out what the license for your code is. I'd recommend doing this for all future projects, as it makes it much easier for people wanting to use your code or package your software what license they have to comply with. Contrary to popular opinion, not specifying a license makes your code proprietary (though you did mention the license at the very end of your README, which is something). [1]: https://github.com/vvviperrr/SimpleRT/pull/2 https://github.com/vvviperrr/SimpleRT/pull/2

codys 10y ago
Specifying license info in every single file is entirely unnecessary and done far too often. Imagine a book including a copyright notice on very single page. The license was specified in the manner the author chose to specify it, and that is sufficient.
- viraptor 10y ago
  https://www.gnu.org/licenses/gpl-howto.en.html https://www.gnu.org/licenses/gpl-howto.en.html > the process involves adding two elements to each source file of your program: a copyright notice (such as “Copyright 1999 Terry Jones”), and a statement of copying permission, saying that the program is distributed under the terms of the GNU General Public License (or the Lesser GPL). Whatever you think about the GNU guys and the license, they do have good lawyers. If they say this is how you should apply GPL to your programs, they're most likely right.
- cyphar 10y ago
  There are two reasons that I don't think this is the same issue as putting a copyright notice on every single page. 1. Each page of a book is not meaningful in of itself in the same way that a particular function in a file is meaningful in of itself. So, there's no real worry that the text will be moved to another place without the appropriate notice being copied along with it (citations and quotations are usually under fair use, and citing a work is usually the only thing you need to do if you copy part of a work). 2. Pages in a book are not like files. If you were talking about pamphlets, the analogy would be more clear. It is not expected that people will tear out pages from a book and then stick them into a new book. It is also not expected that people will only be given a single chapter from a book rather than the whole book. If any of those cases were considered "normal use" of the book, then I would definitely expect people to put a copyright notice on every page. In addition, it isn't common for people to apply different licenses to different pages of the same book. Usually the license and copyright are the same for the entire book. Not to mention that IMO it is aesthetically pleasing to have a nice header in each file, and it doesn't have any ambiguity when you read the code of a project what license applies to which file. Also, it's how all GNU projects do it and I trust their lawyers and opinion on how to correctly display licensing information. It also mentions that this is the recommended way of displaying the license in the actual license text itself. So there's that.

by cyphar 10y ago

codys 10y ago

Specifying license info in every single file is entirely unnecessary and done far too often. Imagine a book including a copyright notice on very single page. The license was specified in the manner the author chose to specify it, and that is sufficient.

viraptor 10y ago
https://www.gnu.org/licenses/gpl-howto.en.html https://www.gnu.org/licenses/gpl-howto.en.html > the process involves adding two elements to each source file of your program: a copyright notice (such as “Copyright 1999 Terry Jones”), and a statement of copying permission, saying that the program is distributed under the terms of the GNU General Public License (or the Lesser GPL). Whatever you think about the GNU guys and the license, they do have good lawyers. If they say this is how you should apply GPL to your programs, they're most likely right.
cyphar 10y ago
There are two reasons that I don't think this is the same issue as putting a copyright notice on every single page. 1. Each page of a book is not meaningful in of itself in the same way that a particular function in a file is meaningful in of itself. So, there's no real worry that the text will be moved to another place without the appropriate notice being copied along with it (citations and quotations are usually under fair use, and citing a work is usually the only thing you need to do if you copy part of a work). 2. Pages in a book are not like files. If you were talking about pamphlets, the analogy would be more clear. It is not expected that people will tear out pages from a book and then stick them into a new book. It is also not expected that people will only be given a single chapter from a book rather than the whole book. If any of those cases were considered "normal use" of the book, then I would definitely expect people to put a copyright notice on every page. In addition, it isn't common for people to apply different licenses to different pages of the same book. Usually the license and copyright are the same for the entire book. Not to mention that IMO it is aesthetically pleasing to have a nice header in each file, and it doesn't have any ambiguity when you read the code of a project what license applies to which file. Also, it's how all GNU projects do it and I trust their lawyers and opinion on how to correctly display licensing information. It also mentions that this is the recommended way of displaying the license in the actual license text itself. So there's that.