3 ms·
The style of this diff is bewildering. What's with the gratuitous reformatting of the whitespace? Makes it difficult for the reader to pick out the meaningful
by honkhonkpants 10y ago
The style of this diff is bewildering. What's with the gratuitous reformatting of the whitespace? Makes it difficult for the reader to pick out the meaningful difference.
- dpark 10y agoI'm looking on a phone, so maybe I'm missing it, but I don't see much gratuitous whitespace change. The only place I see that is in the declaration of hv_storvsc_request.
- hinkley 10y agoDiff tools that can ignore white space changes make code reviews a lot easier.
- tedunangst 10y agoOr one can separate white space diffs from functional diffs and reduce the dependency on particular tooling choices. This often works a lot better because style diffs often reflow lines that -w doesn't handle.
- hinkley 10y agoYou can when you don't work on a team with feature branches, but everybody who failed to understand CI seems to think its a wonderful way to work. And it turns out there are a lot of them.