4 ms·
Summary: Enable -Werror in debug builds, disable it in production builds (in publicly released builds). Reason: -Werror is helpful for you, useless for a 3rd
by ars 10y ago
Summary:
Enable -Werror in debug builds, disable it in production builds (in publicly released builds).
Reason: -Werror is helpful for you, useless for a 3rd party.
- arcticbull 10y agoCame here to say exactly this. No reason you can't be extra careful during development and turn the flags off in release configuration.
- careersuicide 10y agoI agree whole heartedly. When I'm programming I typically want most things that would cause a warning to stop me in my tracks. However I cannot count the number of times I've been trying to build someone else's code and the configuration uses -Werror and things that didn't raise a warning on their version of gcc or clang do on mine and now I've got to fix possibly dozens of not actual errors.
- pixelbeat 10y agoYes exactly. For example GNU coreutils auto enables -Werror for devs when running from a git repo, whereas tarball releases do not add that option. See: http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=blob;f=configure.ac;hb=v8.25#l102 http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=blob;f=confi...
- astrange 10y agoIt's not scalable for you either. If everything becomes an error, you can't go a single day without fixing it and everything the compiler + your dependencies - aka, just some other people you've never met - complains about. In particular if you update a library and they deprecate some functions, -Wdeprecated will start emitting some warnings, which are now errors. Do you think you can fix that in a day? It could take months to fix something that's literally not a problem yet. By the way, I couldn't build MariaDB on this one machine because some plugin we don't use has -Werror set and fails with obscure C++ nonsense.
- 2trill2spill 10y ago> In particular if you update a library and they deprecate some functions, -Wdeprecated will start emitting some warnings, which are now errors. Do you think you can fix that in a day? It could take months to fix something that's literally not a problem yet. It doesn't take months to add -Wno-deprecated to a Makefile.
- powercf 10y ago> It doesn't take months to add -Wno-deprecated to a Makefile. After which you no longer have any visibility on what deprecated fxns you're calling, which means one day updating that library again is going to completely block you until you rework your interface. -Wno-error=deprecated would probably be better.
- MaulingMonkey 10y agoEven better in my experience: A work item to be triaged, generated when you add either.
- Sir_Cmpwn 10y agoBetter if the third parties hit you up with the bug report and you come back with a patch.