3 ms·
Looks very nice! One thing: the "Handle exceptions of setuid() and setgid()" commit message caught my eye, so I took a look: if (setuid(uid) < 0) {
by ckastner 10y ago
Looks very nice!
One thing: the "Handle exceptions of setuid() and setgid()" commit message caught my eye, so I took a look:
if (setuid(uid) < 0) {
fprintf(stderr, "Unable to set process user ID");
}
You probably want to add an exit() here, as well as to the preceeding setgid() call. Also, the earlier initgroups() can fail, too, so its result should also be checked.
- heinrich5991 10y agoLooks like a '\n' is missing there.
- jakobdabo 10y agoWhile we are doing this... #define APP_TIMEOUT (2000000L) /* 2 seconds */ ... usleep(APP_TIMEOUT); usleep limits its argument's range to values from 0 to 1000000 and is considered obsolete. Please use nanosleep instead.
- jonasdn 10y agoThank you, applied :)