4 ms·

> If someone submits a bunch of code, and the only kind of comment on it they get is "there's no newline before this 'continue' statement", Oh, far from it. "N

by dozzie 10y ago

> If someone submits a bunch of code, and the only kind of comment on it they get is "there's no newline before this 'continue' statement", Oh, far from it. "Newline before `continue'" was raised because project's code guidelines clearly required it. And there were other things, like not using a callback function to .foreach() method for something that could be done in place with `foreach' loop. This was commented as "great, more unnecessary work". Not an attitude of somebody who wants to learn. Have you actually read the review comments? > The whole interaction could have gone very differently if someone had thought to include a simple "thank you" in the comments. Well, the "thank you" comment should clearly be said by the Indian guy. Somebody took the effort to teach him in a setting that from the beginning was exactly this: a person learning from a more experienced one. > As it stands, this is just pointless and counterproductive hazing of a new contributor. No. As it stands, it's teaching somebody who came to learn. I remind you again, it's GSoC.

foldr 10y ago
>And there were other things, like not using a callback function to .foreach() method for something that could be done in place with `foreach' loop I didn't see how that was a big deal. People are always going to disagree somewhat about how to structure code. You can't expect contributors to read your mind and write exactly the code that you would have written. That is why this code review strikes me as a bit disingenuous. > Well, the "thank you" comment should clearly be said by the Indian guy. I really don't understand this attitude. Any project should be grateful to people who contribute to it. Personally, I am happy if someone contributes to a project of mine. Their code might not be everything I could have hoped for, but I always thank them for their contribution. If they don't use the same code style as me, I either suck it up and change it myself, or politely ask them if they'd consider resubmitting with the correct style. There is no reason whatever why anyone should be made to feel as if their contributions are unwelcome as a result of such trivial issues. The most basic social graces are sufficient to stop this from happening. And it should be crushingly obvious that it is counterproductive to alienate people who are trying to contribute to your project. >No. As it stands, it's teaching somebody who came to learn. I remind you again, it's GSoC. I think that's a misconception. GSoC is a two-way street. Projects get valuable contributions, and the contributors learn from the process. Each party is benefiting and each should be thankful to the other.
- dozzie 10y ago
  Add also the stipend to the landscape. One party gets the code and needs to merge it to the codebase (more work), and the other party learns and is paid for doing so. If the guy is going to be paid, he should do a decent job, including sticking to project's guidelines. Why should he be paid if he only made more work for the project? > There is no point in giving a line-by-line commentary on how a particular bit of code fails to meet trivial code formatting guidelines. Well, the reviewer explained the thing in the first encountered line, and then pointed all the lines that need the same treatment so the submitter doesn't have to search for them himself. This is why such comments arise when reviewing somebody's code. All in all, the reviewer was not rude. He may be thought of as dry, but certainly not rude. The submitter's attitude, on the other hand, showed an attitude, even if it was him that was benefitting from the conversation, not the reviewer. Something with that is off.
  - foldr 10y ago
    The stipend is paid by Google, not by gnome-games. From their perspective they are getting help for free. If they don't want to encourage that, it's their loss. Putting "n00b" contributors down is an easy way to make yourself feel good, but it doesn't ever benefit the project. This kid could have chosen to do 1001 other things beside contribute to gnome-games. Now he's probably wishing that he did. Who benefits?

by dozzie 10y ago

foldr 10y ago

>And there were other things, like not using a callback function to .foreach() method for something that could be done in place with `foreach' loop I didn't see how that was a big deal. People are always going to disagree somewhat about how to structure code. You can't expect contributors to read your mind and write exactly the code that you would have written. That is why this code review strikes me as a bit disingenuous. > Well, the "thank you" comment should clearly be said by the Indian guy. I really don't understand this attitude. Any project should be grateful to people who contribute to it. Personally, I am happy if someone contributes to a project of mine. Their code might not be everything I could have hoped for, but I always thank them for their contribution. If they don't use the same code style as me, I either suck it up and change it myself, or politely ask them if they'd consider resubmitting with the correct style. There is no reason whatever why anyone should be made to feel as if their contributions are unwelcome as a result of such trivial issues. The most basic social graces are sufficient to stop this from happening. And it should be crushingly obvious that it is counterproductive to alienate people who are trying to contribute to your project. >No. As it stands, it's teaching somebody who came to learn. I remind you again, it's GSoC. I think that's a misconception. GSoC is a two-way street. Projects get valuable contributions, and the contributors learn from the process. Each party is benefiting and each should be thankful to the other.

dozzie 10y ago
Add also the stipend to the landscape. One party gets the code and needs to merge it to the codebase (more work), and the other party learns and is paid for doing so. If the guy is going to be paid, he should do a decent job, including sticking to project's guidelines. Why should he be paid if he only made more work for the project? > There is no point in giving a line-by-line commentary on how a particular bit of code fails to meet trivial code formatting guidelines. Well, the reviewer explained the thing in the first encountered line, and then pointed all the lines that need the same treatment so the submitter doesn't have to search for them himself. This is why such comments arise when reviewing somebody's code. All in all, the reviewer was not rude. He may be thought of as dry, but certainly not rude. The submitter's attitude, on the other hand, showed an attitude, even if it was him that was benefitting from the conversation, not the reviewer. Something with that is off.
- foldr 10y ago
  The stipend is paid by Google, not by gnome-games. From their perspective they are getting help for free. If they don't want to encourage that, it's their loss. Putting "n00b" contributors down is an easy way to make yourself feel good, but it doesn't ever benefit the project. This kid could have chosen to do 1001 other things beside contribute to gnome-games. Now he's probably wishing that he did. Who benefits?