2 ms·

github cheats for performance. our github enterprise will not bother try show diffs on some pull requests if you changed more than a hundred lines or so. very

by gcb0 10y ago

github cheats for performance. our github enterprise will not bother try show diffs on some pull requests if you changed more than a hundred lines or so. very worthless. my workflow now is to always check the diffs locally because i don't trust theirs. never used gitlab or bitbucket a lot so i don't know if this treachery is there too.

sytse 10y ago
I assume you're referring to GitLab.com specifically. We also don't show large diffs, but I think the limit is thousands of lines. In the upcoming release (July 22) we're working on a collapsable diff feature https://gitlab.com/gitlab-org/gitlab-ce/issues/14103 https://gitlab.com/gitlab-org/gitlab-ce/issues/14103 to make working with large diffs easier.
kannonboy 10y ago
Bitbucket engineer here! In Bitbucket Cloud - i.e. bitbucket.org - we cap the diff size for pull requests at 10000 lines. In Bitbucket Server we also cap the number of lines in a particular diff at 10000 by default, but you can override this number[0], along with all other timeouts and thresholds with our various configuration properties. One of the engineering values of the Server team is "no hardcoded constants" - so you can configure basically any property that you like to suit your particular deployment. Both Bitbucket Server and Cloud also generate a subtly different - and in our opinion more correct - diff than you'll find in GitLab and GitHub. Bitbucket actually creates a hypothetical merge commit between your two branches and shows the diff between it and the tip of the target branch. This means we can nicely render merge conflicts in the UI, and show how your target branch will actually be affected by the merge (rather than just the changes on the source branch). I wrote an article that discusses our merge algorithm in more depth[1] a little while ago. [0]: https://confluence.atlassian.com/bitbucketserver/bitbucket-server-config-properties-776640155.html#BitbucketServerconfigproperties-Paging https://confluence.atlassian.com/bitbucketserver/bitbucket-s... [1]: https://developer.atlassian.com/blog/2015/01/a-better-pull-request/ https://developer.atlassian.com/blog/2015/01/a-better-pull-r... edit: correcting my previous statement on diff sizing in Bitbucket Cloud
dmitry-k 10y ago
RhodeCode has a configurable diff limit. There's no problem in displaying 10K+ lines in a diff. https://rhodecode.com/features/productivity https://rhodecode.com/features/productivity In fact, it's a part of our code review/pull request functionality, therefore "it just works".

by gcb0 10y ago

sytse 10y ago

I assume you're referring to GitLab.com specifically. We also don't show large diffs, but I think the limit is thousands of lines. In the upcoming release (July 22) we're working on a collapsable diff feature https://gitlab.com/gitlab-org/gitlab-ce/issues/14103 https://gitlab.com/gitlab-org/gitlab-ce/issues/14103 to make working with large diffs easier.

kannonboy 10y ago

Bitbucket engineer here! In Bitbucket Cloud - i.e. bitbucket.org - we cap the diff size for pull requests at 10000 lines. In Bitbucket Server we also cap the number of lines in a particular diff at 10000 by default, but you can override this number[0], along with all other timeouts and thresholds with our various configuration properties. One of the engineering values of the Server team is "no hardcoded constants" - so you can configure basically any property that you like to suit your particular deployment. Both Bitbucket Server and Cloud also generate a subtly different - and in our opinion more correct - diff than you'll find in GitLab and GitHub. Bitbucket actually creates a hypothetical merge commit between your two branches and shows the diff between it and the tip of the target branch. This means we can nicely render merge conflicts in the UI, and show how your target branch will actually be affected by the merge (rather than just the changes on the source branch). I wrote an article that discusses our merge algorithm in more depth[1] a little while ago. [0]: https://confluence.atlassian.com/bitbucketserver/bitbucket-server-config-properties-776640155.html#BitbucketServerconfigproperties-Paging https://confluence.atlassian.com/bitbucketserver/bitbucket-s... [1]: https://developer.atlassian.com/blog/2015/01/a-better-pull-request/ https://developer.atlassian.com/blog/2015/01/a-better-pull-r... edit: correcting my previous statement on diff sizing in Bitbucket Cloud

dmitry-k 10y ago

RhodeCode has a configurable diff limit. There's no problem in displaying 10K+ lines in a diff. https://rhodecode.com/features/productivity https://rhodecode.com/features/productivity In fact, it's a part of our code review/pull request functionality, therefore "it just works".