4 ms·

https://github.com/magcius/xplain/issues/15 https://github.com/magcius/xplain/issues/15

by daveloyall 10y ago

stonogo 10y ago
Why isn't this just an email to the author?
- daveloyall 10y ago
  "praise in public, criticize in private" ?
  - sdegutis 10y ago
    Personally I'd feel a bit uncomfortable if someone posted that kind of comment to me on Github and HN. I'd be grateful of course, but would feel pretty awkward.
    - Jasper_ 10y ago
      Author here, I'm totally OK with it.
    - codemaster3000 10y ago
      The author seems more than ok with receiving these types of comments and almost seems to be fishing for them... Great writeup, but the number of times he's mentioned that it would be 'ok' to thank him or give him praise seems a bit over the top > If you have any questions or comments, _or just want to thank me_, feel free to email me....
- gkya 10y ago
  Because others can't see it then. Also, it'll appear on his github that he's contributed to the project.
  - daveloyall 10y ago
    That project is a labor of love and the author asked for very little in return, but he did ask for it, publicly: https://github.com/magcius/xplain/blob/gh-pages/article/regions.html#L402-L415 https://github.com/magcius/xplain/blob/gh-pages/article/regi... Had he asked for money, I probably would not have sent any. But he asked for something that I can provide with ease, so I did. And I enjoyed it. Is that really what this is about? Is it wrong to do good if it might benefit the do-gooder in some way? Can we all take a collective moment to think critically about that? :) (anyway, you're wrong(ish?). Posting an issue does not appear to have added my name to https://github.com/magcius/xplain/graphs/contributors https://github.com/magcius/xplain/graphs/contributors . Though I could have sworn that I've seen what you are talking about happen before. \shrug\, that's github's fault.)
    - gkya 10y ago
      An issue tracker is a tracker for issues, not the guestbook to the project. You could've emailed the author, link to him on social media, on your website, submit to reddit etc... but you choose to open an issue on his issue tracker, and put that here on HN in a comment. Even if you intended differently, it's how it look to an outsider. On your last paragraph, yes, github used to show who reports issues as contributed to the project to which they reported. I recall at one point having reported an embarassing silly issue (a very stupid config mistake I made that I don't recall) to Pelican blogware and it went there among the contributed projects as a badge of dishonour. :) But now I checked, that section seems to be gone from the profile page on gihtub.
      - daveloyall 10y ago
        ok, you got me on the "issue trackers are for issues" point.
      - Jasper_ 10y ago
        I don't have social media, and GitHub issues are indeed acceptable for giving public feedback of any sort, though I understand not all projects are ran this way. I clarified this point: https://github.com/magcius/xplain/commit/91fde0e87116ec834f1d500d5757c7229bffbcdb https://github.com/magcius/xplain/commit/91fde0e87116ec834f1...

https://github.com/magcius/xplain/issues/15 https://github.com/magcius/xplain/issues/15

stonogo 10y ago

Why isn't this just an email to the author?

daveloyall 10y ago
"praise in public, criticize in private" ?
- sdegutis 10y ago
  Personally I'd feel a bit uncomfortable if someone posted that kind of comment to me on Github and HN. I'd be grateful of course, but would feel pretty awkward.
  - Jasper_ 10y ago
    Author here, I'm totally OK with it.
  - codemaster3000 10y ago
    The author seems more than ok with receiving these types of comments and almost seems to be fishing for them... Great writeup, but the number of times he's mentioned that it would be 'ok' to thank him or give him praise seems a bit over the top > If you have any questions or comments, _or just want to thank me_, feel free to email me....
gkya 10y ago
Because others can't see it then. Also, it'll appear on his github that he's contributed to the project.
- daveloyall 10y ago
  That project is a labor of love and the author asked for very little in return, but he did ask for it, publicly: https://github.com/magcius/xplain/blob/gh-pages/article/regions.html#L402-L415 https://github.com/magcius/xplain/blob/gh-pages/article/regi... Had he asked for money, I probably would not have sent any. But he asked for something that I can provide with ease, so I did. And I enjoyed it. Is that really what this is about? Is it wrong to do good if it might benefit the do-gooder in some way? Can we all take a collective moment to think critically about that? :) (anyway, you're wrong(ish?). Posting an issue does not appear to have added my name to https://github.com/magcius/xplain/graphs/contributors https://github.com/magcius/xplain/graphs/contributors . Though I could have sworn that I've seen what you are talking about happen before. \shrug\, that's github's fault.)
  - gkya 10y ago
    An issue tracker is a tracker for issues, not the guestbook to the project. You could've emailed the author, link to him on social media, on your website, submit to reddit etc... but you choose to open an issue on his issue tracker, and put that here on HN in a comment. Even if you intended differently, it's how it look to an outsider. On your last paragraph, yes, github used to show who reports issues as contributed to the project to which they reported. I recall at one point having reported an embarassing silly issue (a very stupid config mistake I made that I don't recall) to Pelican blogware and it went there among the contributed projects as a badge of dishonour. :) But now I checked, that section seems to be gone from the profile page on gihtub.
    - daveloyall 10y ago
      ok, you got me on the "issue trackers are for issues" point.
    - Jasper_ 10y ago
      I don't have social media, and GitHub issues are indeed acceptable for giving public feedback of any sort, though I understand not all projects are ran this way. I clarified this point: https://github.com/magcius/xplain/commit/91fde0e87116ec834f1d500d5757c7229bffbcdb https://github.com/magcius/xplain/commit/91fde0e87116ec834f1...