4 ms·
It would be nice if instead of having to comment LGTM a thumbs up reaction on the FP of the PR would suffice
by PuercoPop 10y ago
It would be nice if instead of having to comment LGTM a thumbs up reaction on the FP of the PR would suffice
- bjacobel 10y agoI believe the actual "LGTM" phrase is configurable via a .lgtm file in the root of the repo. Airbnb's Enzyme has it configured to work with a :+1:.
- PuercoPop 10y agoFrom reading the manual I saw it was configurable to change the regexp it matches, not property's of the OP
- bradrydzewski 10y agoLGTM doesn't currently work with GitHub reactions mostly because the API [1] wasn't available back in November when the project was created. I do personally like comments because they are a bit more visible than reactions, which require you to hover over to see more details. Now that the reactions API is available it is certainly possible to enable this sort of functionality. I openly encourage people to fork the project and hack into something that works for their team. [1] https://developer.github.com/changes/2016-05-12-reactions-api-preview/ https://developer.github.com/changes/2016-05-12-reactions-ap...