5 ms·
Paginate pull requests. For the love of all that is holy, paginate pull requests. It's probably the main thing that frustrates the hell out of me when doing cod
by Jemaclus 10y ago
Paginate pull requests. For the love of all that is holy, paginate pull requests. It's probably the main thing that frustrates the hell out of me when doing code reviews. Argh.
- tedmiston 10y agoWhat do you mean? Do you normally have pages and pages of pull requests at one time?
- Jemaclus 10y agoIf you have a lot of files or a lot of lines that get changed, eventually it just cuts off and says "Diff is too large" and won't show me the remaining files, so I have to do the diff manually at the command line. It sucks pretty bad. (Note: our rules suggest small PRs, but occasionally, especially for large rewrites or large features, the PRs can be huge. Lack of pagination makes code reviews extremely difficult, since it just stops showing files, rather than saying "The rest of the files are on the next page.")
- tedmiston 10y agoInteresting. We use GitLab which doesn't seem to have this limitation that I'm aware of. I've used it [GitLab] for PRs up to a few thousand lines.
- jobvandervoort 10y agoWe actually do show this when the diff is too large, but we're improving this with GitLab 8.10. In 8.10 diffs become collapsible, so you can choose to hide / show very large diffs for performance reasons [0] or to make it easier to walk through diffs with many files. [0]: https://gitlab.com/gitlab-org/gitlab-ce/issues/14103 https://gitlab.com/gitlab-org/gitlab-ce/issues/14103
- tedmiston 10y agoI stand corrected, in the best possible way. How exactly does GitLab define "large diff" anyway?
- jobvandervoort 10y agoA large diff has 100 files / 5000 lines in total. A single large file is >=5KB.