3 ms·
> 2 code commits * Squashing commits works like that. * Only having to change a few things to achieve a performance gain is a signature of well-designed softw
by zamalek 10y ago
> 2 code commits
* Squashing commits works like that.
* Only having to change a few things to achieve a performance gain is a signature of well-designed software.
* The second commit touches nearly 1Kloc.
> any tests
Performance improvements aren't supposed to result in a change of behavior (although tests can be reused for benchmarking/profiling). A large test suite[1] that covers behavior already exists.
[1]: https://github.com/Microsoft/ChakraCore/tree/master/test https://github.com/Microsoft/ChakraCore/tree/master/test