4 ms·
Do you all work at companies that don't do design reviews and code reviews? Those seem like good ways to keep people in the loop and get feedback on idea/code.
by jrockway 10y ago
Do you all work at companies that don't do design reviews and code reviews? Those seem like good ways to keep people in the loop and get feedback on idea/code. Code reviews should be interrupts, but nothing else should be.
I find the amount of work one can practically achieve in a day to be a good limiter of how much people will be kept out of the loop if they are not actively engaging in their email (or whatever system people use). The reality is, no matter how fast you think you're moving, it's not that fast.
- mrjn 10y agoWe do pretty strict code reviews https://github.com/dgraph-io/dgraph/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aclosed https://github.com/dgraph-io/dgraph/pulls?utf8=%E2%9C%93&q=i... . Nothing goes into master until it gets LGTMed. The point was that, if all of your team members are having a conversation, but you're not, you'd feel left out. Of course, you might not care, but a lot of people who feel they're active part of the team do; and discourse allows us to do that very well.