3 ms·

Asking the author of a PR to include an automated test is a favor to the larger community - you're building momentum for this practice. As a maintainer, you sho

by btown 10y ago

Asking the author of a PR to include an automated test is a favor to the larger community - you're building momentum for this practice. As a maintainer, you shouldn't feel bad about introducing this sort of hurdle. (And if you don't have the infrastructure to run those automated tests, then it's a good excuse to get it up and running!)

haikuginger 10y ago
> Asking the author of a PR to include an automated test is a favor to the larger community Agreed. Once this practice is in place, it's much easier to keep going - we have 100% coverage on urllib3 and require any new contributions to meet that bar.