4 ms·
Your fix requires a lot of mental CPU cycles on the part of whoever reads the code. Are you sure it wouldn't have been better to do it the simple, obvious way?
by CamperBob2 10y ago
Your fix requires a lot of mental CPU cycles on the part of whoever reads the code. Are you sure it wouldn't have been better to do it the simple, obvious way?
double a = *(double *) dpa;
double b = *(double *) dpb;
if (a > b) return 1;
if (b < a) return -1;
return 0;
- rwmj 10y agoYup I think you are right -- the (fixed) code is very obscure now.
- huhtenberg 10y agoI think it's actually quite elegant. The issue is that it always does two comparisons, even when one would suffice.
- Someone 10y agoDepending on how the compiler computes a>b, it may be branchless, though, and I expect that to be more important on modern CPUs.
- deleted 10y ago[deleted]
- titzer 10y agoThat code returns 0 for all NaN inputs.
- CamperBob2 10y agoTrue enough, but if you're passing NaNs to qsort(), something has already gone wrong in your professional life.
- sijoe 10y agoOh my gosh ... the fortran computed goto is back ... See http://www.lahey.com/docs/lfprohelp/F95ARComputed_GOTOStmt.htm http://www.lahey.com/docs/lfprohelp/F95ARComputed_GOTOStmt.h...