3 ms·
On the flip side - to properly review a 400 line pr would take hours unless you were involved in discussions with the developer along the way like let's say he'
by ChemicalWarfare 10y ago
On the flip side - to properly review a 400 line pr would take hours unless you were involved in discussions with the developer along the way like let's say he's making changes to the api while you're working on the consuming client.
I typically ask for the devs to push their code into the repo incrementally as long as the change doesn't break anything. That way you have manageable prs and if there's a need to go back to the previous version you have smaller deltas to deal with as well.
- crdoconnor 10y ago>I typically ask for the devs to push their code into the repo incrementally That's fine provided each of those PRs gets reviewed and merged almost immediately but if you don't do that then either the developer has to create a separate branch for each incremental improvement (horrible) or let them mount up into a monster pull request (also horrible). Some changes also kind of need to be large in order to not break anything (deep architectural changes).
- ChemicalWarfare 10y agoYea speed is key with incremental prs. Which is on me most of the time as a lead SA on the project. I encourage the devs to slack me directly or drop an @here note in one of the relevant channels. I do the same when submitting prs myself too.