4 ms·
Supporting http/2 SERVER_PUSH seems cool at first glance, but doesn't it significantly increase the attack service for RCE vulnerabilities, being that it accept
by chatmasta 10y ago
Supporting http/2 SERVER_PUSH seems cool at first glance, but doesn't it significantly increase the attack service for RCE vulnerabilities, being that it accepts arbitrary content from remote servers and passes it into a callback function?
It looks like PHP implemented SERVER_PUSH [0] via libcurl [1], openly described as a "work in progress."
I'm sure all the code is "well written", both in PHP and libcurl, but I can't shake the feeling that we'll see at least one significant vulnerability as a result of this new feature. The two github issues on the feature, one referencing a segfault caused by a double-free [2], and one caused by server-specific protocol issues [3], do not help to assuage my worry.
[0] https://wiki.php.net/rfc/curl_http2_push https://wiki.php.net/rfc/curl_http2_push
[1] https://daniel.haxx.se/blog/2015/06/03/server-push-to-curl/ https://daniel.haxx.se/blog/2015/06/03/server-push-to-curl/
[2] https://github.com/curl/curl/issues/529 https://github.com/curl/curl/issues/529
[3] https://github.com/curl/curl/issues/530 https://github.com/curl/curl/issues/530