4 ms·
It's funny that you don't mention the warnings that can be security vulnerabilities, like integer precision/signedness. The code screams security vulnerability
by msim 10y ago
It's funny that you don't mention the warnings that can be security vulnerabilities, like integer precision/signedness.
The code screams security vulnerability and I'm not only talking about the warnings.
- vvanders 10y agoYep, I seem to recall there was one in MySQL a while back that just involved a simple int->char conversion where the overflow would trigger a match due to a random seed that was involved in the password path. I'm a big fan of Wall Werror with pragma for specific sections where you must work around the warnings. Does a great job of catching issues with contributions.