4 ms·
"bisect". Bisect becomes useless if not every commit compiles (or local equivalent). Bisect is a critical feature, even if I don't necessarily use it often, bec
by jerf 11y ago
"bisect". Bisect becomes useless if not every commit compiles (or local equivalent). Bisect is a critical feature, even if I don't necessarily use it often, because when I need it, I need it.
As long as I can bisect, I don't much care about the details. But this is definitely not compatible with three dozen commits mostly consisting of "oops didn't compile" and "forgot comma" and "fix syntax erorr". You've gotta do something about that.
The way some people talk, the only acceptable history is an asciinema [1] recording of the development process with a microphone recording the developer's mutterings as it goes. The question isn't about what information you "lose" but about what you keep, because you must discard the vast bulk of it. We're arguing here about whether we chuck 99.97% or 99.99% of it.
[1]: https://asciinema.org/ https://asciinema.org/
- _ikke_ 11y agoBisect also becomes useless because of large commits. Even if you find the commit, the change it introduces can be so large you don't git much improvement. Git allows you to clean up your feature branches to prevent these kind of fix commits. Look at git.git. They don't require people to squash all their commits into a single patch, but still every patch should be compilable.
- jerf 11y ago"As long as I can bisect, I don't much care about the details." If I can't bisect, I don't approve. So, by simple logic based on the premise you supply, I also disapprove of large commits. My point may not be what you expected prior to reading.
- juped 11y agoThen your comment makes no sense in context, because you replied to my complaint that people lose information by doing these giant squash merges and having no nontrivial graph structure in their main project history.
- jerf 11y agoThere are positions other than the extremes. My position makes sense, yes, in context too.
- junke 11y agoNot saying that you should keep everything, but your argument does not take into account "git bisect skip", which works both manually and automatically. https://git-scm.com/docs/git-bisect https://git-scm.com/docs/git-bisect.
- cyphar 11y agoI never liked git bisect skip, becuase the bug you're tracking down somehow always manages to be in a set of 3 or 4 commits, of which you can't build 2. Maybe I'm just lucky.
- junke 11y agoYou can't blame git bisect skip for that. Note also that many other commits that could not build did not contain the bugs ;-) (Speaking of luck, I worked with a codebase where the bug was always inside a jumbo commit involving at least a hundred of files)
- cyphar 11y agoI know, but I prefer codebases where skipping a commit isn't necessary -- because it always fills me with dread. ;)