2 ms·
A couple of points we can address here: Agree on the NodeList.prototype reassign - not a well informed decision (see source comments around its inclusion). We
by adamduncan 10y ago
A couple of points we can address here:
Agree on the NodeList.prototype reassign - not a well informed decision (see source comments around its inclusion). We think it's worth correcting: https://github.com/frend/frend.co/issues/64 https://github.com/frend/frend.co/issues/64
Fully aware of the less-than-ideal DOM traversal in places - this is ripe for improvement: https://github.com/frend/frend.co/blob/gh-pages/_components/tabs/tabs.js#L126 https://github.com/frend/frend.co/blob/gh-pages/_components/...
Let's shift the focus from code style to getting these components tested and improved for all users.