4 ms·
Pre-commit code reviews quickly hammer all those different kinds of people into the same kind of nail. It's one of the best aspects of code review as a practic
by CydeWeys 11y ago
Pre-commit code reviews quickly hammer all those different kinds of people into the same kind of nail. It's one of the best aspects of code review as a practice, yet it doesn't get as much attention as code quality and correctness.
It is worth putting the time into refactoring things properly and looking over every line of the diff to make sure it belongs on my team. If you do this, your code can often pass review with only a few comments, even for a change that's hundreds of lines long. If you didn't send good code out for code review ... god help you. You're going to be buried in dozens of comments ("the beatings will continue until the code improves").
There's certainly an adjustment process when people join our team and our company. But ensuring consistency across our entire codebase is absolutely worth it. And I know that I have become a better developer by consistently being held to high standards, and doing the same of others.