3 ms·
You can also refuse changes for being too big to review. Creating incentives for small changes seem like a good thing to me, so I don't see where you complaint
by jupp0r 10y ago
You can also refuse changes for being too big to review. Creating incentives for small changes seem like a good thing to me, so I don't see where you complaint is.
- gurkendoktor 10y agoAs I said, review culture can also create incentives against small commits, because they will often be over-analysed. I've seen this sentiment on the internet, so it can't just be my own anecdata. https://twitter.com/girayozil/status/306836785739210752 https://twitter.com/girayozil/status/306836785739210752 Not to mention trivial commits, like clarifying comments, something which doesn't happen anymore in my current project - nobody can be bothered to go through the review process for that. I'm not against code reviews, but I prefer casual post-commit reviews for uncontroversial changes.