3 ms·
There's a line to walk for sure. When I code review a line that looks like this: $foo=fn1($bar) &&$baz = fn2 ($qux) I always send it back. Do I look pedanti
by Domenic_S 10y ago
There's a line to walk for sure. When I code review a line that looks like this:
$foo=fn1($bar) &&$baz = fn2 ($qux)
I always send it back. Do I look pedantic? Probably, but to me consistency is important. It's about caring about what you're doing. If I see a line like this, I assume the person who wrote it doesn't pay a lot of attention to detail and I pay closer attention to the rest of their commit. I mean, if you can't be troubled to set your IDE preferences to the team/project's rules, what's that say about you?
- eterm 10y agoIsn't that in part a linting issue? I figure code reviews are for reviewing stuff that can't be corrected by a computer.