4 ms·
If your changes are generally-useful to the userbase, your code is fully tested, and it doesn't break any existing features, I'd just submit a pull-request to g
by MalcolmDiggs 10y ago
If your changes are generally-useful to the userbase, your code is fully tested, and it doesn't break any existing features, I'd just submit a pull-request to get the conversation going.
You never know, someone on the main team might have had the same idea for the feature long ago, but never mentioned it or had time to implement.
As far as new-branch vs master branch, go with whatever precedent the repo has laid out. (Review recent pulls, and any guidance the authors have laid out in the docs). It's a personal preference thing for the authors, there's not really a right or wrong way.
- elbigbad 10y agoThanks for the response. It works pretty well, but probably not in 100% of cases, so it could use a little tweaking from someone more knowledgeable of the codebase. It doesn't break anything else though for sure. Really liked working on this though, want to continue development, and don't want to get a bad reputation with the creator by flubbing things on my first pull.