3 ms·

the problem arises when you try to directly access the element with id="bob" e.g. bob.innerHTML this will work on explorer and is called global namespace pol

by eusman 19y ago

the problem arises when you try to directly access the element with id="bob" e.g. bob.innerHTML this will work on explorer and is called global namespace polluting. and it could get things mixed up. So, a good practise is not to name DOM elements with javascript variables. The reason you never ran into the problem is because that locally you create a variable with a reference to the DOM element, so you are practising a "workaround"

gruseom 19y ago
I'm afraid I don't follow. Creating a variable that references a DOM element (whose ID equals the variable name) is not a "workaround", it's the thing that's supposed to produce an error in IE. I'm not seeing that error. What do I need to change in what I described above in order to produce it?
- axod 19y ago
  See my post above for an example of an error that arises from this.
aston 19y ago
Actually, I'd argue that relying on magical global variables mapping to page elements is bad practice in the first place. If you want an element by ID, that's what document.getElementByID is for (or $ if you're using a JS framework). If you want a form element by its name (why not it's id?), you should go out to get that specifically.
- gruseom 19y ago
  My JS is compiled from higher-level source; at the source level there is no duplication and it's simpler to use a variable. Moroever, using getElementById is 60% slower than a global variable in FF and more than 10x slower in IE. For the app I'm building, this matters a lot.
  - aston 19y ago
    Of course it's faster to use a precomputed reference than to find an element in the DOM. I can't see the "overhead" of manually storing a reference to a DOM element in a variable ever mattering in any application. Grab it once and you're done.
    - eusman 19y ago
      the only sure thing is that the whole javascript perfomance/memory footprint/cross-browser/degrade challenge can drive someone crazy!

by eusman 19y ago

gruseom 19y ago

I'm afraid I don't follow. Creating a variable that references a DOM element (whose ID equals the variable name) is not a "workaround", it's the thing that's supposed to produce an error in IE. I'm not seeing that error. What do I need to change in what I described above in order to produce it?

axod 19y ago
See my post above for an example of an error that arises from this.

aston 19y ago

Actually, I'd argue that relying on magical global variables mapping to page elements is bad practice in the first place. If you want an element by ID, that's what document.getElementByID is for (or $ if you're using a JS framework). If you want a form element by its name (why not it's id?), you should go out to get that specifically.

gruseom 19y ago
My JS is compiled from higher-level source; at the source level there is no duplication and it's simpler to use a variable. Moroever, using getElementById is 60% slower than a global variable in FF and more than 10x slower in IE. For the app I'm building, this matters a lot.
- aston 19y ago
  Of course it's faster to use a precomputed reference than to find an element in the DOM. I can't see the "overhead" of manually storing a reference to a DOM element in a variable ever mattering in any application. Grab it once and you're done.
  - eusman 19y ago
    the only sure thing is that the whole javascript perfomance/memory footprint/cross-browser/degrade challenge can drive someone crazy!