3 ms·

The Laravel framework [1]. It makes the most of the latest features available in PHP (reflection, traits, namespacing, etc.) and its author, Taylor Otwell, has

The Laravel framework [1]. It makes the most of the latest features available in PHP (reflection, traits, namespacing, etc.) and its author, Taylor Otwell, has an almost obsessive attitude with the naming of methods and formatting of the source code. For instance, every multiline comment is exactly three lines long, and every line is three characters shorter than the previous one [2]. [1] https://github.com/laravel/framework https://github.com/laravel/framework [2] https://www.reddit.com/r/laravel/comments/20ovey/just_noticed_this_its_like_this_in_every_config/cg5w2x6 https://www.reddit.com/r/laravel/comments/20ovey/just_notice...

raziel2p 10y ago
Laravel is a pretty bad codebase, making use of reflection or just assuming methods are present instead of interfaces, actively laughing in the face of static typing. They're also awful at managing issues/bugs, where they'll gladly close issues without explanation, or close an issue when a pull request gets submitted, only to reject the pull request and not re-open the issue.
- raphaelsaunier 10y ago
  Fair enough, you seem to have contributed quite a bit to the framework after all [1]. However, don't you think they have gotten better with triaging as of late? Also, I'm wondering, does your criticism still apply to the latest versions of Laravel or does it stem from frustrations with the pre-5.0 versions? Regarding your comments about the lack of interfaces, it's worth mentioning that at least the core components do have an interface now [2]. [1] https://github.com/laravel/framework/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Aanlutro https://github.com/laravel/framework/pulls?utf8=%E2%9C%93&q=... [2] https://laravel.com/docs/master/contracts#contract-reference https://laravel.com/docs/master/contracts#contract-reference
noir_lord 10y ago
Posted laravel then saw your comment, I agree it is one of the cleanest PHP codebases out there. Also good is https://github.com/symfony/symfony/tree/master/src/Symfony/Component https://github.com/symfony/symfony/tree/master/src/Symfony/C...

raziel2p 10y ago

Laravel is a pretty bad codebase, making use of reflection or just assuming methods are present instead of interfaces, actively laughing in the face of static typing. They're also awful at managing issues/bugs, where they'll gladly close issues without explanation, or close an issue when a pull request gets submitted, only to reject the pull request and not re-open the issue.

raphaelsaunier 10y ago
Fair enough, you seem to have contributed quite a bit to the framework after all [1]. However, don't you think they have gotten better with triaging as of late? Also, I'm wondering, does your criticism still apply to the latest versions of Laravel or does it stem from frustrations with the pre-5.0 versions? Regarding your comments about the lack of interfaces, it's worth mentioning that at least the core components do have an interface now [2]. [1] https://github.com/laravel/framework/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Aanlutro https://github.com/laravel/framework/pulls?utf8=%E2%9C%93&q=... [2] https://laravel.com/docs/master/contracts#contract-reference https://laravel.com/docs/master/contracts#contract-reference

noir_lord 10y ago

Posted laravel then saw your comment, I agree it is one of the cleanest PHP codebases out there. Also good is https://github.com/symfony/symfony/tree/master/src/Symfony/Component https://github.com/symfony/symfony/tree/master/src/Symfony/C...