3 ms·
Pokemon Showdown's code quality impressed me when I looked at it: https://github.com/Zarel/Pokemon-Showdown https://github.com/Zarel/Pokemon-Showdown It's not
by jtolmar 10y ago
Pokemon Showdown's code quality impressed me when I looked at it: https://github.com/Zarel/Pokemon-Showdown https://github.com/Zarel/Pokemon-Showdown
It's not literally flawless (hard to find conceptual entry points, short on comments), but when you get to the massive piles of one-off special functions needed to simulate all of Pokemon's moves and abilities (e.g. https://github.com/Zarel/Pokemon-Showdown/blob/master/data/abilities.js https://github.com/Zarel/Pokemon-Showdown/blob/master/data/a... ) it's all much more succinct than I'd have expected. The file I linked expresses more "business logic" in 3300 lines than is contained in the entire 40kiloline codebases of some of the enterprise monstrosities I've worked on.
- partycoder 10y agoCode organization could use some work. A lot of shared mutable state. Event listeners are subscribed with "on" instead of "once" for one time events... that's all I could find in like 30 seconds... Disqualified
- jack9 10y agoHigh Code Quality is not synonymous with perfect. Your critique is disqualified.