55 ms·
Memory management in C++ is not automatic. You have to choose between unique_ptr and shared_ptr (among others), and getting it wrong results in use after free,
by pcwalton 11y ago
Memory management in C++ is not automatic. You have to choose between unique_ptr and shared_ptr (among others), and getting it wrong results in use after free, which can be exploitable. Not using weak_ptr in the right place results in memory leaks. And so forth.
- vmarsy 11y agoIf you make good use of move semantics and return value optimizations. you can avoid using pointers in many more cases in the first place. Using pointers only where really needed reduces your risk of memory leaks.
- pjmlp 11y agoWhile true, it only works if everyone plays ball. What I learned in my C and C++ years of enterprise coding is that I want to stay away from those codebases. C++ can be lovely when used in small teams of skilled developers that play by the rules. On typical enterprise code, with various skill sets of developers that come and go, many from consulting companies, it can be a huge pain to maintain and track down memory corruption issues.
- CyberDildonics 11y agoThat's fine, but protecting you from other people doing ridiculous things isn't really the fault of modern C++ as it is possibly a feature of a GC language. I think there is utility in not letting people out of a sandbox if they can't handle it, but I also think the fact that C++11 has a stark path that should be used is different than the high wire act of C and older C++.
- pjmlp 11y agoIt is a fault of C++, because there are other systems programming languages also without GC, that aren't as memory corruption friendly as C and C++. They achieve that by either being older than C, or never being copy-paste compatible with it. This is the biggest drawback of C++, even modern C++. C compatibility was a good way to achieve adoption, but also what hinders the language in terms of safety. It doesn't matter how many safety features the language has, you always have a few cowboys coders doing "C with C++ compiler" style. In the majority of typical enterprises where code review and static analyzers are foreign words, you get into horrible code bases. I like the language a lot, it is the language I liked most to use after Turbo Pascal, used to teach it to first year students and have a few jobs on my CV where I really enjoyed using it. Nowadays I rather use it in personal projects as infrastructure language alongside other ones where I can easily follow modern practices, rather than on the job in codebases where developers come and go.
- pcwalton 11y agoThose ridiculous things are things we find everyone does again and again, even in modern C++. C++11 doesn't really add anything in the safety department over smart pointer code that you could write in earlier versions of C++.
- pjmlp 11y agoQuite true, the only thing that C++11 does is make it part of the standard library and offer a few language features that make it more pleasant to the eye. I was already using smart pointers with COM in 1998, but of course most of the third party libraries we depended on, did not.
- maccard 11y agoThat's great until you work with any third party libraries.
- CyberDildonics 11y agoThird party libraries don't really interfere though, they can be used the same as always or wrapped up in a class that implements move semantics.
- pcwalton 11y agoYou have to use references and iterators, which are just as dangerous.
- CyberDildonics 11y agoPragmatically though I don't use either because they are wrapped up in data structures. With copy elision and move semantics memory basically does become automatic on a day to day basis. When I am making my own data structures I basically use unique_ptr or just use std::vector directly. I've used shared_ptr in one relatively exotic situation and no other time. I'm actually not even sure what you mean when you say use after free - I rarely expose a naked pointer, and when I do the lifetime and ownership are pretty obvious. I like Rust and I'm not trying to downplay its significance, but I think you are misjudging the reality of working in C++11 - memory leaks and use after free don't seem to be an issue to me after having done nothing but C++11 for three years.
- pcwalton 11y ago> I'm actually not even sure what you mean when you say use after free - I rarely expose a naked pointer, and when I do the lifetime and ownership are pretty obvious. Reference and iterator invalidation, usually. > I think you are misjudging the reality of working in C++11 - memory leaks and use after free don't seem to be an issue to me after having done nothing but C++11 for three years. It continues to be an issue for us and every other browser vendor, despite widespread adoption of C++11 throughout the codebase. Large C++ apps that are believed immune to UAF typically just haven't been the target of people actively looking for holes.