2 ms·
In this specific case, sure. But it's not really about this specific case; it's about the general idea of "I know that this won't fail, even though you, the com
by steveklabnik 11y ago
In this specific case, sure. But it's not really about this specific case; it's about the general idea of "I know that this won't fail, even though you, the compiler, do not." Unless you have full-on dependent types, (and even then), there's going to be times where that's true; it's the nature of type systems. They have to be conservative, there will always be valid programs that are not expressible.
- lmm 11y agoI feel like that's just a special case of casting and so should be handled by casting. You can always cast Optional to Some, can't you? It's verbose and dangerous-looking but it should be verbose and dangerous-looking in my book.
- steveklabnik 11y agoIt depends on the language. In a language like Rust, direct casts mean "reinterpret these bits", and the two are represented differently, so that wouldn't work. In a less low-level language, then sure, maybe a cast would work for this case. I'm not sure that it's any more verbose or scary looking, though.
- lmm 11y ago> In a language like Rust, direct casts mean "reinterpret these bits", and the two are represented differently, so that wouldn't work. What's the representation of an optional then? Doesn't make use of some generic concept like subclasses or unions? Surely you have a generic syntax for "assume this union is this particular member" or "assume this base class is this particular subclass" or the like? > I'm not sure that it's any more verbose or scary looking, though. I guess the point is that I want all cast-like operations to look alike (or at least to have a way to consistently distinguish them from ordinary methods) so that I can flag them all up consistently in code reviews, linters etc.
- steveklabnik 11y agoIt's a tagged union. Sometimes the tag can be elided, sometimes not. If you did a direct cast, you'd lose the tag. More specifically though, layout is undefined, so you don't know if the tag is first or last, strictly speaking. Lints for unwrap already exist :)
- lmm 11y ago> It's a tagged union. Sometimes the tag can be elided, sometimes not. If you did a direct cast, you'd lose the tag. More specifically though, layout is undefined, so you don't know if the tag is first or last, strictly speaking. Do you not have a generic syntax for unwrapping a tagged union, forcibly assuming that it's one particular component? That seems like something users would want.
- steveklabnik 11y agoThat is exactly what unwrap() is... (More specifically, it's a method which uses `match` internally to do this)
- lmm 11y agoOk, so I'm advocating forcing users to always use match directly if they want to do that. That helps ensure unsafe code looks unsafe.
- tatterdemalion 11y agoMaybe your issue is that the `get` method in Java sounds pretty innocuous, but in Rust the `unwrap` method is notorious. Every Rust user knows that it can panic. Requiring a match would increase verbosity and decrease clarity.
- pcwalton 11y agoWhy add a language feature when a library feature does the same thing?