4 ms·
Makes sense, but there are ways of being even petty and nitpicky without being condescending or rude. State facts, don't throw insults, don't demean or belittle
by Niksko 11y ago
Makes sense, but there are ways of being even petty and nitpicky without being condescending or rude. State facts, don't throw insults, don't demean or belittle.
- coredog64 11y agoOne good rule I was given by a tech lead is to not use the word "you" in the PR comments. PR comments are a discussion on the failure of the code, not of the individual. Avoiding "you" allows for some separation between the two.
- cachemiss 11y agoI always use "we", and I almost always phrase things as a question. Example: "So we are doing X here, which I think will probably do Y, which could have adverse affects Z, are we sure we want to do this?"