4 ms·
Sorted by +1s: https://github.com/issues?q=is%3Aopen+is%3Aissue+sort%3Areactions-%2B1-desc https://github.com/issues?q=is%3Aopen+is%3Aissue+sort%3Areac... Here
by shoyer 10y ago
Sorted by +1s: https://github.com/issues?q=is%3Aopen+is%3Aissue+sort%3Areactions-%2B1-desc https://github.com/issues?q=is%3Aopen+is%3Aissue+sort%3Areac...
Here are the top three:
1. Contribution graph can be harmful to contributors (https://github.com/isaacs/github/issues/627 https://github.com/isaacs/github/issues/627)
2. proposal: generic programming facilities (https://github.com/golang/go/issues/15292 https://github.com/golang/go/issues/15292)
3. Proper tabs for open files (https://github.com/Microsoft/vscode/issues/224 https://github.com/Microsoft/vscode/issues/224)
Can't say I'm terribly surprised!
- gyhchang 10y agoThe first link 404's for me, is it working for everyone else?
- ekns 10y agoFunny how it says there's 479830 pages worth of results and even has a link to that "last page". I checked and in practice it "only" returns the first 400 pages of results.
- stephengillie 10y agoThat sounds like an issue. I wonder if someone's reported it...
- g_sch 10y agoIsn't this because deep pagination is really costly? I've seen other production systems (especially using elasticsearch) where this limit is in place. From Elastic: >Deep Paging in Distributed Systems >To understand why deep paging is problematic, let’s imagine that we are searching within a single index with five primary shards. When we request the first page of results (results 1 to 10), each shard produces its own top 10 results and returns them to the coordinating node, which then sorts all 50 results in order to select the overall top 10. >Now imagine that we ask for page 1,000—results 10,001 to 10,010. Everything works in the same way except that each shard has to produce its top 10,010 results. The coordinating node then sorts through all 50,050 results and discards 50,040 of them! >You can see that, in a distributed system, the cost of sorting results grows exponentially the deeper we page. There is a good reason that web search engines don’t return more than 1,000 results for any query. https://www.elastic.co/guide/en/elasticsearch/guide/current/pagination.html https://www.elastic.co/guide/en/elasticsearch/guide/current/...
- ashmud 10y agoThe primary product I work on limits (on-screen) results to 10k results (after any filtering) regardless of page size. Aside: However, this was based on our most complicated queries at the time, which have since been simplified.
- scrollaway 10y agoIt also seems impossible to get beyond page 400 on either of those results. https://github.com/issues?page=400&q=is%3Aopen+is%3Aissue&utf8=%E2%9C%93 https://github.com/issues?page=400&q=is%3Aopen+is%3Aissue&ut...
- lunactic 10y agoFun that the first one is also the one with the most -1s
- siddhant 10y agoProbably off topic, but how do you get such a sort to work nicely (sorting on count from another table), without creating redundant data (in this case, maintaining the +1 count in the main issue table as well as maintaining a separate table for +1s), or just delegating the sort to an external search service?
- takno 10y agoThere's no obvious reason why it would be particularly slow to get counts from another table. You're probably going to want to offer full text searches and searches on columns you wouldn't choose to index online as well though, at which point using a search service makes most sense
- morgante 10y agoKeep in mind that has a heavy bias towards newer issues (since +1s are new). Here are the most commented/contentious issues: https://github.com/issues?q=is%3Aopen+is%3Aissue+sort%3Acomments-desc https://github.com/issues?q=is%3Aopen+is%3Aissue+sort%3Acomm...