4 ms·
It will be in Windows builds in 47: https://bugzilla.mozilla.org/show_bug.cgi?id=1248461 https://bugzilla.mozilla.org/show_bug.cgi?id=1248461 . I don't think w
by tedmielczarek 11y ago
It will be in Windows builds in 47: https://bugzilla.mozilla.org/show_bug.cgi?id=1248461 https://bugzilla.mozilla.org/show_bug.cgi?id=1248461 .
I don't think we intended to ship the Rust bits by default, but we didn't disable them for release builds, so there you go. It is pretty tiny, just a little bit of mp4 parsing code that (IIRC) we're running in parallel with the existing C++ code:
https://dxr.mozilla.org/mozilla-central/source/media/libstagefright/binding/mp4parse https://dxr.mozilla.org/mozilla-central/source/media/libstag...
If you run your Firefox from a console and browse sites that serve you shady mp4 files you can see the occasional panic message as it fails to parse something! :)
- mbrubeck 11y agohttp://bugzil.la/1243363 http://bugzil.la/1243363 is where Rust code was enabled for Firefox 45 beta/release on Linux and Mac. If I understand correctly, having it disabled on Firefox 45 beta broke the build because of a script that tests whether the beta build config matches the nightly config. This forced a decision, and release engineering opted to enable it. So it wasn't planned long in advance, but it was a conscious decision at the time 45 went to beta.
- tedmielczarek 11y agoThanks for digging that up. I recall having the discussions where we thought we'd let it bake for a while before it shipped, but I guess it was intentional, even if a bit last-minute. :) It's a pretty small bit of code right now, and it's not on the critical path for anything, so I don't think it's harmful.