3 ms·
I'm not sure about Instagram, but Facebook is a fan of rebasing in general. Nothing should ever appear as a commit in master that isn't something that should b
by nbm 10y ago
I'm not sure about Instagram, but Facebook is a fan of rebasing in general. Nothing should ever appear as a commit in master that isn't something that should be used in production - ie, should never intentionally be broken in isolation.
In general, feature branches are relatively very short-lived, and will be code reviewed, rebased and landed as a single commit onto master.
Features are often feature flagged off anyway, so it is acceptable to commit partially-functional features to master while that feature is flagged away.
There is a concept of stacked commits, but each commit in the stack needs to be a working step towards the end goal, and as such can (and will) be landed in isolation as they are code reviewed.
- serge2k 10y ago> Nothing should ever appear as a commit in master that isn't something that should be used in production - ie, should never intentionally be broken in isolation. I don't understand why people do it any other way.
- ihsw 10y agoSome people Ctrl+S and commit every few files, to keep from pushing changes to 10+ files in a single commit.