2 ms·
Whitespace and similar low hanging fruit should be flagged by scripts and fixed by submitter before reviews by humans take place. As much as possible of other
by osivertsson 11y ago
Whitespace and similar low hanging fruit should be flagged by scripts and fixed by submitter before reviews by humans take place.
As much as possible of other coding rules should be handled by scripts as well.
Talk to people and tell them to only submit merge request when they really believe they are done. If they need help before that it is better to ask coworkers for informal feedback on variable naming etc.
Added: If you are in 'constant crunch mode' then maybe you are wearing out your engineers and they just stop caring about quality?
- kspaans 11y agoAnd if the whole project isn't consistently formatted enough for your team to turn on a linter, then considering doing it only for incoming patches!