4 ms·

The referenced pull request for removing the <span>s (https://github.com/facebook/react/pull/5753 https://github.com/facebook/react/pull/5753) is terrific - a r

The referenced pull request for removing the <span>s (https://github.com/facebook/react/pull/5753 https://github.com/facebook/react/pull/5753) is terrific - a real paragon of open-source professionalism.

joshmanders 11y ago
Agreed. I'm really impressed by the professionalism shown by all members of the React ecosystem. Just the other day I had noticed a org member of the reactjs org (houses react-router, redux, etc) who was acting very unprofessional and expressed that it was a turn off seeing official members of the org basically telling a issue reporter/discussion was "annoying them" and Ryan Florence stepped up and said he was not tolerating that and even reached out to me on Twitter apologizing and saying that they do not condone such tones.
- bubtubgub 11y ago
  The react community is great, in stark contrast to the angular community.
- jfhollingworth 11y ago
  Out of interest, do you have a link to the github issue?
- t81798112 11y ago
  "professionalism", "reached out to me"? When will this blathering in open source stop?
- automathematics 11y ago
  That community specifically has been rude to me too. Eager to see that change for the better!
spicyj 11y ago
+1 to this. High-quality code from @mwiencek right out of the gate, and he was super responsive to my comments when I asked for changes. We're really grateful for the contribution.
- adriancooney 11y ago
  And thank YOU for your fantastic work on React.
  - Scarbutt 11y ago
    Its no like he does it for free. (not saying it in a bad sense)
    - spicyj 11y ago
      Well, I did for a year and a half.
- Vignitus 11y ago
  Where should I start if I want to contribute ?
  - jankassens 11y ago
    There is a tag on some Github issues "good first bug" that should be a good start. https://github.com/facebook/react/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+bug%22 https://github.com/facebook/react/issues?q=is%3Aissue+is%3Ao... I think a lot of the core folks also hang out on IRC at #reactjs on freenode.
    - ConAntonakos 11y ago
      I think they're on Discord now on the Reactiflux server.
- mwiencek 11y ago
  Hey, I didn't expect that to get as much love as it has, but that's really wonderful. Being highlighted in the release notes is super cool. :) I'll just say, it was thanks to the constructive/encouraging help I got on the PR that I was able to finish it.
kough 11y ago
I must be getting jaded - my first thought was that you were being sarcastic, so I was really pleasantly surprised when I browsed through. You're right, this is actually fantastic.
- forrestthewoods 11y ago
  Same! I kept reading and re-reading trying to find who did something offensive.
faitswulff 11y ago
Do you happen to know what the thinking is behind having all the changes in one commit? I imagine it would make for a much neater master branch.
- spicyj 11y ago
  Yes, that's one prime motivation. In this particular PR, it's not clear that it could have been split up into any smaller logical commits since a lot of the code is interdependent.
ludwigvan 11y ago
Won't this break things that relied on span's being there? I'm thinking it should have been opt-in initially. Or is it that way since it is a major version? Specifically, in the old way, there were spans, and we had css styles targeting the spans sometimes.
- warfangle 11y ago
  On the other hand, it vastly simplifies some of my CSS. Those spans screw up whitespace in text. And can really throw a wrench into flexbox layouts. That's the only time I'm targeting them... To fix what they screw up.
  - ludwigvan 11y ago
    That's true. Same in our case as well.

joshmanders 11y ago

Agreed. I'm really impressed by the professionalism shown by all members of the React ecosystem. Just the other day I had noticed a org member of the reactjs org (houses react-router, redux, etc) who was acting very unprofessional and expressed that it was a turn off seeing official members of the org basically telling a issue reporter/discussion was "annoying them" and Ryan Florence stepped up and said he was not tolerating that and even reached out to me on Twitter apologizing and saying that they do not condone such tones.

bubtubgub 11y ago
The react community is great, in stark contrast to the angular community.
jfhollingworth 11y ago
Out of interest, do you have a link to the github issue?
t81798112 11y ago
"professionalism", "reached out to me"? When will this blathering in open source stop?
automathematics 11y ago
That community specifically has been rude to me too. Eager to see that change for the better!

spicyj 11y ago

+1 to this. High-quality code from @mwiencek right out of the gate, and he was super responsive to my comments when I asked for changes. We're really grateful for the contribution.

adriancooney 11y ago
And thank YOU for your fantastic work on React.
- Scarbutt 11y ago
  Its no like he does it for free. (not saying it in a bad sense)
  - spicyj 11y ago
    Well, I did for a year and a half.
Vignitus 11y ago
Where should I start if I want to contribute ?
- jankassens 11y ago
  There is a tag on some Github issues "good first bug" that should be a good start. https://github.com/facebook/react/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+bug%22 https://github.com/facebook/react/issues?q=is%3Aissue+is%3Ao... I think a lot of the core folks also hang out on IRC at #reactjs on freenode.
  - ConAntonakos 11y ago
    I think they're on Discord now on the Reactiflux server.
mwiencek 11y ago
Hey, I didn't expect that to get as much love as it has, but that's really wonderful. Being highlighted in the release notes is super cool. :) I'll just say, it was thanks to the constructive/encouraging help I got on the PR that I was able to finish it.

kough 11y ago

I must be getting jaded - my first thought was that you were being sarcastic, so I was really pleasantly surprised when I browsed through. You're right, this is actually fantastic.

forrestthewoods 11y ago
Same! I kept reading and re-reading trying to find who did something offensive.

faitswulff 11y ago

Do you happen to know what the thinking is behind having all the changes in one commit? I imagine it would make for a much neater master branch.

spicyj 11y ago
Yes, that's one prime motivation. In this particular PR, it's not clear that it could have been split up into any smaller logical commits since a lot of the code is interdependent.

ludwigvan 11y ago

Won't this break things that relied on span's being there? I'm thinking it should have been opt-in initially. Or is it that way since it is a major version? Specifically, in the old way, there were spans, and we had css styles targeting the spans sometimes.

warfangle 11y ago
On the other hand, it vastly simplifies some of my CSS. Those spans screw up whitespace in text. And can really throw a wrench into flexbox layouts. That's the only time I'm targeting them... To fix what they screw up.
- ludwigvan 11y ago
  That's true. Same in our case as well.