3 ms·
By the way, the bandaid solution lowers the latency not just for each request, but also each queued request waiting for CPU time making the reduction in time cu
by ryao 11y ago
By the way, the bandaid solution lowers the latency not just for each request, but also each queued request waiting for CPU time making the reduction in time culminative. As long as the bandaid solution keeps the maximum queue depth and average time spent processing low enough, it would probably suffice. If the spikes remain low under load tests, implementing it would be more of an exercise in seeing how much you can reduce CPU time in this code path for the sake of reducing it than it would be a useful improvement.
That is not meant to discount the fun that one can have when using overkill to eliminate the potential for historical issue to resurface in some new situation. It can be very fun, as long as one does not spend too much time on it. I have been known to do it on occasion:
https://github.com/zfsonlinux/spl/commit/0b43696e6676391e5bee8ba49e76e599bac1d89d https://github.com/zfsonlinux/spl/commit/0b43696e6676391e5be...