4 ms·
> Yes, code review is an invaluable part of the git history. It explains why you made the decisions you made. This is interesting - even places I've worked tha
by HolyHaddock 11y ago
> Yes, code review is an invaluable part of the git history. It explains why you made the decisions you made.
This is interesting - even places I've worked that have cared about commit messages have been pretty happy with the entirely content-free "Fixes from code review."
Do you summarise code review discussions in the commit messages?
- Touche 11y agoYes, I do, I try to treat each commit like something that can be read in isolation. But nevertheless, the merge commit will have (if using GitHub) a reference to the pull request where you can see the discussion, which is valuable imo.
- HolyHaddock 10y agoHave you had any feedback from colleagues that have found that useful?