3 ms·
What I got from this article is idea to squash every pull req into a single commit. I think this is valuable idea.
by desireco42 11y ago
What I got from this article is idea to squash every pull req into a single commit. I think this is valuable idea.
- xori 11y agoI agree, which github now does for you https://github.com/blog/2141-squash-your-commits https://github.com/blog/2141-squash-your-commits
- desireco42 11y agothank you for pointing this out for me
- ionforce 11y agoIt's such a naive idea to apply this to every PR unilaterally.
- cyphar 11y agoAs someone who does a lot of git bisecting, this is a horrible idea. Only do it on a case-by-case basis. If it takes 5 commits to make 5 complete changes that implement something, keep them as 5 commits.