7 ms·

Thanks. I've not done any of that as I didn't come up with the patch to begin with. I'll do some research and work out where the legalities fall.

by NamTaf 11y ago

voltagex_ 11y ago
You may want to coordinate with the PC-BSD people as they seem to have an interest in it being upstreamed, too. https://bugs.pcbsd.org/issues/2361 https://bugs.pcbsd.org/issues/2361
- cperciva 11y ago
  Some of the PC-BSD people on that thread are FreeBSD people too. I'm guessing someone simply forgot about it at some point...
  - voltagex_ 11y ago
    I'm still not clear on the lines between projects. Seems like people work together more than the various Linux distros.
voltagex_ 11y ago
I'm halfway down the rabbit hole - I have to create an account to view the original patch. No license header. https://gist.github.com/voltagex/160980fc680d830b8b7e68199a3dca02 https://gist.github.com/voltagex/160980fc680d830b8b7e68199a3... (sorry about Windows line endings) http://forums.nas4free.org/viewtopic.php?f=69&t=2974 http://forums.nas4free.org/viewtopic.php?f=69&t=2974 Does the BSD license apply to a patch to a BSD licensed file?
- cyphar 11y ago
  > Does the BSD license apply to a patch to a BSD licensed file? No, because the BSD License isn't copyleft. You'll have to contact the original author as well as any contributors.
  - voltagex_ 11y ago
    Good luck! 6 posts on that forum then disappeared forever.
    - viraptor 11y ago
      Not that hard. Google "hcb nas4free" and get: https://lists.freebsd.org/pipermail/freebsd-bugs/2013-March/052180.html https://lists.freebsd.org/pipermail/freebsd-bugs/2013-March/... (Hielke Christian Braun) The author already submitted this patch in 2013 - since it was contributed to the project, it should be fine regarding the license.
      - voltagex_ 11y ago
        Yeah, I shouldn't have posted the flippant comment. Sorry. I've posted the bug tracker links in another comment - looks like there's some concerns about the effects of the patch on high-end networking gear.
    - cyphar 11y ago
      I don't understand the flippant comment. You asked a legitimate question and I gave a legitimate answer? Is there some joke I missed?
      - voltagex_ 11y ago
        Sorry. I was in a bad mood and it seemed like the user was going to be hard to track down. I hate those old forums that make you sign in before you can download attached files, and loose patch files floating around remind me why Git isn't all that bad.
- NamTaf 11y ago
  If I got the patched file that I made for 10.x, got it working again, generated a patch and threw it up as a gist would that help you? I would struggle to trace the steps where I got the file initially; I'll see what I can do. Basically, trying to make heads or tails of the licensing issues surrounding it, especially given the fact that I don't remember many of the sources, is where I struggle to know what to do to do the 'right' thing.

Thanks. I've not done any of that as I didn't come up with the patch to begin with. I'll do some research and work out where the legalities fall.

by NamTaf 11y ago

Thanks. I've not done any of that as I didn't come up with the patch to begin with. I'll do some research and work out where the legalities fall.

voltagex_ 11y ago

You may want to coordinate with the PC-BSD people as they seem to have an interest in it being upstreamed, too. https://bugs.pcbsd.org/issues/2361 https://bugs.pcbsd.org/issues/2361

cperciva 11y ago
Some of the PC-BSD people on that thread are FreeBSD people too. I'm guessing someone simply forgot about it at some point...
- voltagex_ 11y ago
  I'm still not clear on the lines between projects. Seems like people work together more than the various Linux distros.

voltagex_ 11y ago

I'm halfway down the rabbit hole - I have to create an account to view the original patch. No license header. https://gist.github.com/voltagex/160980fc680d830b8b7e68199a3dca02 https://gist.github.com/voltagex/160980fc680d830b8b7e68199a3... (sorry about Windows line endings) http://forums.nas4free.org/viewtopic.php?f=69&t=2974 http://forums.nas4free.org/viewtopic.php?f=69&t=2974 Does the BSD license apply to a patch to a BSD licensed file?

cyphar 11y ago
> Does the BSD license apply to a patch to a BSD licensed file? No, because the BSD License isn't copyleft. You'll have to contact the original author as well as any contributors.
- voltagex_ 11y ago
  Good luck! 6 posts on that forum then disappeared forever.
  - viraptor 11y ago
    Not that hard. Google "hcb nas4free" and get: https://lists.freebsd.org/pipermail/freebsd-bugs/2013-March/052180.html https://lists.freebsd.org/pipermail/freebsd-bugs/2013-March/... (Hielke Christian Braun) The author already submitted this patch in 2013 - since it was contributed to the project, it should be fine regarding the license.
    - voltagex_ 11y ago
      Yeah, I shouldn't have posted the flippant comment. Sorry. I've posted the bug tracker links in another comment - looks like there's some concerns about the effects of the patch on high-end networking gear.
  - cyphar 11y ago
    I don't understand the flippant comment. You asked a legitimate question and I gave a legitimate answer? Is there some joke I missed?
    - voltagex_ 11y ago
      Sorry. I was in a bad mood and it seemed like the user was going to be hard to track down. I hate those old forums that make you sign in before you can download attached files, and loose patch files floating around remind me why Git isn't all that bad.
NamTaf 11y ago
If I got the patched file that I made for 10.x, got it working again, generated a patch and threw it up as a gist would that help you? I would struggle to trace the steps where I got the file initially; I'll see what I can do. Basically, trying to make heads or tails of the licensing issues surrounding it, especially given the fact that I don't remember many of the sources, is where I struggle to know what to do to do the 'right' thing.