3 ms·
Had similar problems. Atm our protocol works for us - maybe for you too: - It is expected that you do PR reviews every morning - It is expected that you
by andreasklinger 11y ago
Had similar problems.
Atm our protocol works for us - maybe for you too:
- It is expected that you do PR reviews every morning
- It is expected that you wait for 2x +1's ([1])
- It is expected that every comment is addressed either with a comment or code
- that way people can give 2 comments and give +1 and move on
Minor rule: "Code style" discussions are made explicit in code linters and shouldnt (repetitive => linter rule) happen in PRs
Minor rule: If people dont like to review a PR, the PR is too big or not properly prepared (explanations [2], no committer comments, no screenshots, etc) or both
Most important rule: PR Reviews are meant to enable the committer to do a better job - not to "code check"
Hope that helps! GL.
[1]: http://cl.ly/2M3K1I0s380m/Image%202016-04-03%20at%2019%3A04%3A45.png http://cl.ly/2M3K1I0s380m/Image%202016-04-03%20at%2019%3A04%... (2 days b/c weekend usual cycle time is 24-48h)
[2]: http://cl.ly/1w3s2y0m0T2H/Image%202016-04-03%20at%2019%3A12%3A27.png http://cl.ly/1w3s2y0m0T2H/Image%202016-04-03%20at%2019%3A12%...