4 ms·
I'll start by answering based on my last gig (at a startup). ===== > Do you think Engineering managers are aware how much time you spend on Code Reviews? No.
by verst 11y ago
I'll start by answering based on my last gig (at a startup).
=====
> Do you think Engineering managers are aware how much time you spend on Code Reviews?
No.
> Do you track your number of / time spent on code reviews? Does your manager?
Me: Only informally (might mention it during stand-up).
Manager: No.
> Are code reviews valued as much / more / less than writing new code? Why / Why not?
Valued less. Manager did not seem to value code review as a worthy task.
> How are code reviews prioritized against writing code for bug fixes, or implementing new features?
Code reviews are not planned in the work load :(. Engineers have to try to carve out time for code reviews.
> How do you choose a code reviewer?
I usually assign reviews to the engineer who knows the feature best or with whom I have the best working relationship. Sometimes I assign to the engineers who will get to my code review the soonest.
> Do you ensure code reviews are distributed across the team? If not, how would you do it? How do you ensure you are not doing too many reviews yourself?
No. Might be nice to have a team queue for code reviews and the engineering manager making sure that everybody participates in reviews.