4 ms·
We do both here. For some code, eg shared libraries, we're distributed so it has to be via PR. Better than that though is OTS review, which is what we practis
by nevster 11y ago
We do both here.
For some code, eg shared libraries, we're distributed so it has to be via PR.
Better than that though is OTS review, which is what we practise on our projects where we're all in the same cubicles.
Basically, when we're ready to commit code, we call another team member over and walk through the changes. Besides catching bugs, this often results in refactoring - things like renaming stuff to make it understandable (one of the most crucial problems in coding) and extracting methods. This is so much more effective and less time consuming than the typical PR process.