3 ms·
My team uses Fisheye + Crucible. We have an expectation that outstanding reviews will be handled end of day and beginning of day (some people work staggered shi
by ebbv 11y ago
My team uses Fisheye + Crucible. We have an expectation that outstanding reviews will be handled end of day and beginning of day (some people work staggered shifts, so they may have reviews awaiting them when they start in the morning.)
Additionally, we will do reviews for each other as we return from lunch or on a break between issues, etc. as possible for each person.
Revisiting a revised review is handled the same way. If I put up a review and there are defects found that need to be handled, I'll handle those and then add the resulting commit(s) to the review and let the team know (though they will check their Crucible inbox when they get a chance anyway.)
If a review is holding other things up we can be pests about it if necessary, but it's up to the other devs to decide when they have time to take a look. It's not up to me.
Since the reviewers and reviewees are all on the same team together we are all motivated to take care of reviews. If you're not all on the same team, or your team doesn't have a healthy "We're all in this together." that could be problematic.