3 ms·
The company I work for is using microservices, I usually I try to focus on how the app behaves, and make sure the UI works & there are no bugs. I do also read t
by joshribakoff 11y ago
The company I work for is using microservices, I usually I try to focus on how the app behaves, and make sure the UI works & there are no bugs. I do also read the code itself to make sure there's no blatant security issues, but I try to focus my review on the app's behavior more than it's code, since a microservice can be easily rewritten later if any problems come to our attention. If the person writing that app chose to copy/paste instead of use inheritance, I'll assume they have a good reason. Code quality is important, but no one even cares about it besides the developers. Usually I'll also ask the developer if there's any parts of the code they'd like constructive advice on, that way I don't come off as if I'm lecturing them when I do critique their code.