5 ms·
The problem I often run into is people making a bunch of comments but not having the confidence to actually make a call (ship or no ship). I think this has root
by wonnage 11y ago
The problem I often run into is people making a bunch of comments but not having the confidence to actually make a call (ship or no ship). I think this has roots in the idea of code review as a way to cover your ass when something goes wrong.
This would be nice:
As a reviewer, your responsibility is to say whether the code is shippable or not; the remaining content is simply justification
As a submitter, you determine who needs to see your code, and this is a flexible thing - if you paired with the people who would be reviewing your code anyway, maybe getting approvals from all of them is unnecessary, etc.